Skip to content

fix(telemetry): record an allowlist of HTTP headers on Maple's Workers - #1453

Merged
JeremyFunk merged 2 commits into
mainfrom
fix/effect-4-0-4-http-span-defaults
Oct 14, 2026
Merged

JeremyFunk merged 2 commits into
mainfrom
fix/effect-4-0-4-http-span-defaults

fix(telemetry): apply the effect v4 review of the header allowlist

4c8b40e
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 14, 2026 in 3m 1s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge
Header capture is a bounded allowlist pinned by tests on both the alchemy bridge and the client path; the tracer fix only narrows when a ResponseError is treated as a rendered 5xx.
quality 100/100 · no findings · tests covered · risk medium

Restores an allowlisted set of HTTP request/response headers on Maple's Worker spans and stops the SDK relabelling a failed response write as a rendered 5xx. Contained to telemetry wiring; safe to merge.

  • MapleHttpTracingLive allowlists the request and response headers recorded on HTTP spans
  • runtimeTelemetry adds the allowlist to the three Durable Object runtimes via telemetry.layer
  • isStatusOnlyResponseError keeps a write-failure ResponseError as its own exception

Before merge

  • Manual · Confirm the three prod alerts and five Agent Sessions widgets updated outside the code are live against the new span data
What was checked
  • Allowlist carries no credential: x-clickhouse-key, authorization and set-cookie stay off the span (worker-telemetry.test.ts:32)
  • The bridge path records cf-ray and drops authorization/cookie (apps/electric-sync/src/worker-bridge.test.ts:167)
  • turn-runner, apply-proposal and relay/run still consume telemetry.layer/flush after the switch

4c8b40e · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.