Skip to content

feat(previews): sign in to PR previews with a shared access key - #1506

Merged
Makisuo merged 4 commits into
mainfrom
feat/preview-sign-in
Oct 15, 2026
Merged

feat(previews): sign in to PR previews with a shared access key#1506
Makisuo merged 4 commits into
mainfrom
feat/preview-sign-in

docs(agents): how to sign in to a PR preview

20464fd
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 15, 2026 in 24s

Confidence 8/10 · No issues found

🟢 Confidence 8/10 · likely safe to merge
Only CLAUDE.md changed since b198288; the one open issue is a trim mismatch the form's key.trim() still cannot satisfy.
quality 98/100 · 1 note · tests covered · risk medium · 1/1 new units observable

Only CLAUDE.md changed since the last review: a docs section on signing in to PR previews. The code itself was reviewed at b198288 and is safe to merge, with one open issue — the server compares PREVIEW_SIGNIN_KEY untrimmed while the form trims its input.

  • CLAUDE.md documents preview:signin <n> and the shared Preview reviewer

Before merge

Still open from earlier reviews

Production impact

Production traffic of the changed files (last 7 days)
File Calls/day Busiest operations
scripts/preview-seed-smoke.ts 983 POST 834/day, 3.9% err
POST 145/day, 0.5% err
POST /internal/demo/seed 4/day, 0.0% err
apps/web/src/lib/preview-sign-in.ts 979 POST 834/day, 3.9% err
POST 145/day, 0.5% err
scripts/preview-signin.ts 979 POST 834/day, 3.9% err
POST 145/day, 0.5% err
packages/backend/src/services/auth/PreviewSignInService.ts 5 Clerk.users.getOrganizationMembershipList 5/day, 0.0% err
Telemetry this change adds and removes (1)
  • ➕ span name PreviewSignInService.signIn · packages/backend/src/services/auth/PreviewSignInService.ts:94
What was checked
  • Only CLAUDE.md (+19/-0) differs from b198288; the other 16 files are untouched, no new source to read
  • The preview gate still needs auth mode clerk, a pr-<n> stage and an sk_test_ key (PreviewSignInService.ts:65-67)
Observability coverage: 1 of 1 changes observable
Change Kind Observable Evidence
Clerk Backend API calls in clerkPort (getUserList, createUser, getOrganizationMembershipList, createOrganization, createSignInToken) Client yes clerkRequest span names appear as maple-api operations with Clerk. names (5/day, p95 354 ms)

20464fd · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot