Repository navigation
fix(macos): detect the running Host during bootstrap recovery - #377
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f712690 to
e00b8d9
Compare
|
@coderabbitai review |
|
e00b8d9 to
3a105ec
Compare
14799a9 to
1b7fdf8
Compare
3a105ec to
1af9eb8
Compare
1b7fdf8 to
e9db948
Compare
1af9eb8 to
aa3f156
Compare
|
Note 🤖 Codex responding on behalf of Microck @coderabbitai review |
|
Note
🤖 Codex responding on behalf of Microck
mac recovery could report the persistent service inactive while it was running. the probe checked
satelle-host, but the installed launchd label isdev.microck.satelle.host. its process check also expected a bare executable name, while macOS reports the full path.both recovery snapshots now use the installed label and full process arguments. the existing unknown-result and exact-claim guards stay in place. a running host still prevents recovery of an interrupted state-owner release, including paths with spaces.
40 matching tests, formatting and workspace clippy passed in Crabbox. a live read-only mac check confirmed the actual launchd service and the corrected matcher found Host PID 57200. this fixes the probes; it does not clear or resolve the retained restart claim.