Skip to content

fix(macos): detect the running Host during bootstrap recovery - #377

Merged
Microck merged 1 commit into
mainfrom
fix/macos-recovery-service-probe
Oct 5, 2026
Merged

Microck merged 1 commit into
mainfrom
fix/macos-recovery-service-probe

Conversation

@Microck

@Microck Microck commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Note

🤖 Codex responding on behalf of Microck

mac recovery could report the persistent service inactive while it was running. the probe checked satelle-host, but the installed launchd label is dev.microck.satelle.host. its process check also expected a bare executable name, while macOS reports the full path.

both recovery snapshots now use the installed label and full process arguments. the existing unknown-result and exact-claim guards stay in place. a running host still prevents recovery of an interrupted state-owner release, including paths with spaces.

40 matching tests, formatting and workspace clippy passed in Crabbox. a live read-only mac check confirmed the actual launchd service and the corrected matcher found Host PID 57200. this fixes the probes; it does not clear or resolve the retained restart claim.

@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
satelle Ready Ready Preview Oct 5, 2026 12:24pm UTC

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: Microck/satelle/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 44337eb1-e381-4344-b8b7-d6edfd241878
📥 Commits

Reviewing files that changed from the base of the PR and between b3b98f2 and aa3f156.

📒 Files selected for processing (2)
  • .facts
  • crates/satelle/src/bootstrap-lock.rs
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Microck

Microck commented Oct 5, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Microck
Microck changed the base branch from main to fix/installer-signal-ownership October 5, 2026 11:39
@Microck
Microck force-pushed the fix/macos-recovery-service-probe branch from e00b8d9 to 3a105ec Compare October 5, 2026 11:39
@Microck
Microck force-pushed the fix/installer-signal-ownership branch from 14799a9 to 1b7fdf8 Compare October 5, 2026 11:46
@Microck
Microck force-pushed the fix/macos-recovery-service-probe branch from 3a105ec to 1af9eb8 Compare October 5, 2026 11:46
@Microck
Microck force-pushed the fix/installer-signal-ownership branch from 1b7fdf8 to e9db948 Compare October 5, 2026 12:22
@Microck
Microck force-pushed the fix/macos-recovery-service-probe branch from 1af9eb8 to aa3f156 Compare October 5, 2026 12:22
@Microck
Microck changed the base branch from fix/installer-signal-ownership to main October 5, 2026 13:18
@Microck

Microck commented Oct 5, 2026

Copy link
Copy Markdown
Owner Author

Note

🤖 Codex responding on behalf of Microck

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Microck
Microck merged commit eefa6e9 into main Oct 5, 2026
40 of 48 checks passed

This branch was successfully deployed

1 active deployment
Preview — aa3f1569 Deployed Oct 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant