Conversation
- upgrade motrixsim to 0.10.1.dev123565, whose compile_write supports compile-time reset and forward_kinematic flags - semantic writes (ctrl targets, body pose/velocities, kp/damping/mass/ com/friction overrides, mocap poses) compile into one native WritePlan; each execute scatters in a single FFI call, applies the native reset first when compiled with reset=True, and refreshes kinematics at most once - mocap pose declarations expand into per-body interleaved BodyPosition/BodyRotation fields; buffer(name) synthesizes the neutral (N, B, 7) layout as one zero-copy slice, so consumers are unchanged - dof-channel writes keep the numpy scatter path but land through the explicit set_dof_pos/set_dof_vel setters: SceneData property projections are read-only copies, so in-place patches never reached the sim state - keep compile-time conflict detection for dof and ctrl targets with the existing error messages; native duplicate-channel rejection covers the override fields - drop _MultiTargetOp (unused after the migration) and the post-reset op branch (all remaining numpy ops fold into the reset state) Closes #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
Summary
0.10.1.dev123565, whosecompile_writesupports compile-timeresetandforward_kinematicflagsWritePlan; each execute scatters in a single FFI call, applies the native reset first when compiled withreset=True, and refreshes kinematics at most onceBodyPosition/BodyRotationfields;buffer(name)synthesizes the neutral(N, B, 7)layout as one zero-copy slice, so consumers are unchangedset_dof_pos/set_dof_velsetters:SceneDataproperty projections are read-only copies, so in-place patches never reached the sim state_MultiTargetOp(unused after the migration) and the post-reset op branch (all remaining numpy ops fold into the reset state)Test plan
prek runclean on changed files