Repository navigation
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
tpn
force-pushed
the
codex/xpois-lazy-fits-main-20260930
branch
from
October 5, 2026 02:43
0f278f7 to
bedf42f
Compare
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
from
October 5, 2026 02:48
08a39e6 to
cd776e0
Compare
tpn
force-pushed
the
codex/xpois-lazy-fits-main-20260930
branch
from
October 9, 2026 19:12
bedf42f to
e91c262
Compare
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
from
October 9, 2026 20:46
cd776e0 to
bed540e
Compare
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
2 times, most recently
from
October 15, 2026 18:05
0bd3868 to
9aa4b56
Compare
Fuse Gaussian model and analytic Jacobian evaluation while preserving the reference weighted normal contractions and solver behavior. Keep CuPy as the default and expose the optional backend through xFit and the device pipeline, with real CLI and scientific coverage. Signed-off-by: Trent Nelson <trentn@nvidia.com>
Include the Numba-CUDA-MLIR installation extra and device-fit backend argument in the existing public contract assertions. Signed-off-by: Trent Nelson <trentn@nvidia.com>
Keep the device signature and shared pipeline diagnostics consistent when native and Numba-CUDA-MLIR execution are both available. Signed-off-by: Trent Nelson <trentn@nvidia.com>
Allow dynamic CUDA array and stream exports in GPU-enabled type checks. Signed-off-by: Trent Nelson <trentn@nvidia.com>
tpn
force-pushed
the
codex/numba-xfit-main-20260930
branch
from
October 16, 2026 18:47
9aa4b56 to
d940e53
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gaussian fits repeatedly evaluate the model and analytic derivatives through CuPy expressions. Add an optional Numba-CUDA-MLIR backend that combines this work into separate residual and weighted-Jacobian CUDA kernels, with per-thread kernel reuse and explicit stream/buffer lifetimes. CuPy normal-equation contractions, the LM solver and final diagnostics are preserved.
Install
cuphoton[numba-cuda-mlir]on Linux with CUDA 13 and select--backend numba-cuda-mlir. The selection also flows through device-pipeline configuration and bulk execution. Gaussian difference/split modes support float32/float64, masks and variance weights; sampled models and finite differences fail explicitly. Existing backend defaults and fallbacks are preserved.Public synthetic tests cover scientific parity, solver edge cases, concurrent fits, delayed producer streams and actual CLI selection. The xScan-to-xFit inference test compares both backends through the CLI. GPU CI requires these tests to run without skips, and the existing Gaussian benchmark accepts the new backend for warmed comparisons. Builds on #82.
Validation on the integrated source (Python 3.12, CUDA 13):