Repository navigation
shell: e2e — D60's bar waited for whole, not read after a fixed pause (#850) - #851
Merged
Merged
Conversation
…e row, the width (#850) Its row read « Confidential meetingNothing leaves this computer » when it failed: both words there, so the mark not written within 3 s or the window too narrow failed it, which the row alone did not say. The check is the same; what it shows when it fails is all of it. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#850) Turned confidential, the bar adds a row and its window grows to it, asynchronously. Its two checks read the window's height 0.3 s after the gesture: a loaded machine outruns that, and the check failed with every word of the row there. Now waited for as a state, `whole`, within five seconds, before each check — and so before the screenshot that follows it. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kitokey-marc Bot
added a commit
that referenced
this pull request
Nov 15, 2026
… cancelled one does (#845) The same race, in a_transcript_ended_by_kitokey_ends_with_what_it_started_and_is_not_written: its child checked the instant the answer came, with `kill -0`, which a zombie not yet reaped still answers. It failed #851's attest and #836's. Now waited for with `gone`, zombie-aware, within half a second. Without the group's KILL in `end`, it still fails. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
13 of 18 tasks
napkinstack-agent Bot
pushed a commit
that referenced
this pull request
Nov 15, 2026
…checked the instant it is answered (#845) (#846) * shell: a cancelled transcription's deaf child is waited for as gone, not checked the instant it is answered (#845) The KILL sent, the child is gone once the kernel has delivered it and reaped it: on a loaded runner, after the answer (#812's CI, run 43596085957). Now polled as a state for half a second after the answer; the two seconds' bound kept on the answer itself, read before. Without the group's KILL, it still fails: « still runs half a second after the answer ». Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * shell: a transcript ended by Kitokey waits for its child gone, as the cancelled one does (#845) The same race, in a_transcript_ended_by_kitokey_ends_with_what_it_started_and_is_not_written: its child checked the instant the answer came, with `kill -0`, which a zombie not yet reaped still answers. It failed #851's attest and #836's. Now waited for with `gone`, zombie-aware, within half a second. Without the group's KILL in `end`, it still fails. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: kitokey-marc[bot] <356215105+kitokey-marc[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The transcription tests' children waited for as gone on main: this branch's attest no longer carries #845's race. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kitokey-marc Bot
added a commit
that referenced
this pull request
Nov 15, 2026
…eciders-key D60's bar waited for whole on main: confidential_kept no longer reads its height after a fixed pause in this branch's e2e. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
11 of 17 tasks
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shell: e2e — D60's bar waited for whole, not read after a fixed pause
Closes #850.
Module
modules/shell— exactly one.cross-modulelabel is required, justification belowDeliverable
Out of cycle: #850. The window's e2e scenario
confidential_kept(D60) failed in #825's attest, and it runs in every shell e2e, so it can block any attest. It is outside the freeze for that reason (the coordinator, 2026-11-15).What it changes
Only the e2e,
scripts/e2e_window.py, inconfidential_kept:fits:scrollHeightagainstclientHeight) after a fixedtime.sleep(0.3): the French « the bar holds whole » and the English « … on, the window whole ». A loaded machine outruns the pause.whole, the content within the window, withwait_forup to 5 s. The screenshots that follow each check therefore start from a bar at rest. This istests.md§5's rule: wait for an observable state, never a duration.{marked, row, fits}: the mark written, the row's words, and the window's heights.Oracle
FAIL in English, « Confidential meeting — nothing leaves this computer », on, the window whole, gotConfidential meetingNothing leaves this computer;d60-2-small-on-dark.confidential_keptrun alone 5 times on 8052f0b (main and the detail's print) passed 5 of 5, 38 ok each, both height checks among them. The coordinator'srepeat-r850b.txt.Kind of oracle: the e2e itself, its race taken out.
Review budget
Contracts
Definition of Done
python3 -m py_compile; ruffF,PLW2901finds nothing new (the findings left are shell: the e2e scripts pass ruff's F and PLW2901, before the hook that holds them to it #820's)whole's comment says why it waitsTest sheet
Verifier: session 92ded11e-58ef-492d-ba56-c820b9011de8
confidential_keptat this head, when it runs alone, then both height checks pass, waiting for the bar to be whole, with no fixed pause before eitherKITOKEY_E2E_ONLY=confidential_keptat 862cf88, itse2e.txtread here: 38ok, noFAIL; « on, with its context, the bar holds whole — 440 wide, as tall as it shows » ok (l.9), « in English, … on, the window whole » ok (l.31); « its checks passed — not the module's e2e ». Read at the head: notime.sleepbefore either check, each waits onwholeup to 5 s Run again at 37236d3 (main merged, the diff unchanged): 38ok, noFAIL, the same two checks ok (l.9, l.31).confidential_keptpasses, its English check and the screenshot after it includede2e.txtread here: 1793ok, noFAIL, « e2e: passed ». Inconfidential_kept: « on, with its context, the bar holds whole — 440 wide, as tall as it shows » ok (l.655), « in English, « Confidential meeting — nothing leaves this computer », on, the window whole » ok (l.677), and the screenshot after it, « d60-2-small-on-dark: the screenshot is dark », ok (l.678) — where #825's attest had timed outwholefalse), when the scenario runs, then both checks fail, the English one showing{marked, row, fits}whole = lambda b: False(numstat 1 1): 36ok, exactly twoFAIL, the two checks: the firstgot: ([271, 271], [440, 271]), the English onegot: {'marked': True, 'row': 'Confidential meetingNothing leaves this computer', 'fits': [271, 271]}; « FAILED » Run again at 37236d3, same mutant (1 1): 36ok, the same twoFAILand nothing else, the samegot:.Verifier's remarks: (1) The two
time.sleepleft inconfidential_kept(0.3 s inseen, 0.4 s before the first screenshot) come before screenshots, not checks: out of #850's scope unless a screenshot raced. (2)wholereadsfitstwice per look; harmless, the content's height does not shrink while the window grows, so a look passes no earlier than it should. (3) S3's Englishfits[271, 271] holds on a real window: the mutant forces the check, as asked; the window itself was whole.Summary
DONE
whole, within 5 s, before both of D60's checks that read it.VERIFIED
py_compileand ruff.main(660d93f, shell: a killed transcription's children are waited for as gone, not checked the instant it is answered (#845) #846) merged in: the full shell e2e green under the attest's load,confidential_keptincluded; sam's sheet.ASSUMED
fits), not the mark. The row's words were there, and the height is the one read after a fixed pause; the detail now says which if it comes back.NOT VERIFIED
RISKS
Signals to report
🤖 Generated with Claude Code