Repository navigation
D56 — shell: the list of models read again is taken only signed by the decider's key, now built in - #825
Merged
napkinstack-agent[bot] merged 7 commits intoNov 15, 2026
Conversation
… decider's (red) The key built in is the decider's, by its number (28AD0E835D7AF31E). Under it, a list signed by another key, changed after the decider signed it, or unsigned is refused for its signature; the list on main with the decider's signature is taken. The test lists are signed by a key the test makes, or are main's with the signature the decider made of it. The e2e's W reads the list again through the window the same way. Red: no key is built in. Taken up from #643, by dime-hermes. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: dime-hermes[bot] <349604419+dime-hermes[bot]@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nder it (D56) `registry::PUBLIC_KEY`, `minisign public key 28AD0E835D7AF31E`, made in the decider's own terminal. Settings offer the list read again from then on; one unsigned, signed by another key or changed since is refused, and said. The list in the repository is signed by the decider alone, its .minisig committed beside it. Taken up from #643, by dime-hermes. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: dime-hermes[bot] <349604419+dime-hermes[bot]@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…le (D56) models.json.minisig, made by the decider in their own terminal over models.json at 1d6ee69 (sha256 1627839e…046b), verified by minisign -Vm against kitokey-models.pub. Both public. A change to models.json is signed again by the decider. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: dime-hermes[bot] <349604419+dime-hermes[bot]@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… says so (D56) `LEGACY_ALLOWED`, false, named where `verify` passes it. The test's lists are signed by a key made outside it (openssl's Ed25519, minisign's boxes; its private key not kept), the same bytes both ways: pre-hashed, verified; legacy, refused. With `true` passed, the test fails (ines's survivor on #825). Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eciders-key The transcription tests' children waited for as gone on main: this branch's attest no longer carries #845's race. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eciders-key D60's bar waited for whole on main: confidential_kept no longer reads its height after a fixed pause in this branch's e2e. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 15, 2026
…eciders-key The e2e finds a start's tray item in a second: this branch's attest saves about 20 minutes. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-agent
Bot
deleted the
shell-d56-list-signed-by-the-deciders-key
branch
November 15, 2026 13:32
kitokey-lina Bot
added a commit
that referenced
this pull request
Nov 15, 2026
…built it in — and #825's scenario unfolds « Modèles à télécharger » first (#782) With the decider's key in `registry::PUBLIC_KEY` since #825, `registry_waits` was always false and « La liste ne peut pas encore être mise à jour : elle attend la clé qui la signe » never said: removed, with its flag, its field in both languages and its test. WITHOUT_COMMENT lowered to 596. list_refreshed now unfolds « Modèles à télécharger », folded since this pull request, before it reads and presses « Mettre à jour la liste ». Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
napkinstack-agent Bot
pushed a commit
that referenced
this pull request
Nov 15, 2026
…ement asked for this computer, « cet ordinateur » said (#782, #859, #775) (#866) * shell: test — Settings' follow-up of D95: « Modèles à télécharger » folded, no agreement for this computer, « cet ordinateur » said (#782, #859, #775), the oracle alone BN: « Modèles à télécharger » a disclosure, closed at first, kept as left when drawn again; « Refaire le réglage » in « Général » (already so: held). BG: no agreement asked for the stand-in on this computer, nor for one's own address there, one for a host elsewhere (#859); the save said « cet ordinateur », not an address and a port (#775). Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * shell: Settings' follow-up of D95 — « Modèles à télécharger » folded, no agreement asked for this computer, the save said « cet ordinateur » (#782, #859, #775) - « Modèles à télécharger » is a disclosure (ARIA APG), as « Avancé »: closed at first, the list, its refresh and its sentence under it, kept as the user left it over the page's drawings (#782). - A transcription service on this computer asks for no agreement, chosen above or typed under « Avancé »: none is owed there, as the shell already judges (#859). - Saved there, it says « cet ordinateur transcrira… », never its address and port (#775); a new sentence, service_saved_here, commented on its field. Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * shell: e2e — BG writes this computer's Whisper models itself, so that it reads the same alone as in the whole run Played alone (KITOKEY_E2E_ONLY), BG found no model on this computer: main() writes them in K, which a partial run does not play. Seen in the coordinator's runs of the Settings follow-up, at ce2ed51 and cd3c244 alike: « on this computer: the models said by name… », got []. K's, when it ran, are kept. Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * shell: e2e — Z saves OpenRouter's stand-in on this computer with no agreement to tick, as #859 has it (#866) #866's attest at 2e02fa7 stopped in Z: it ticked the agreement for the stand-in on 127.0.0.1, which #859 now hides, and the click raised (ElementNotInteractableException). Z now checks that no agreement is asked there and saves; a host elsewhere is still agreed to above, under « Avancé ». Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * shell: the list's sentence for a key not yet built in removed — #825 built it in — and #825's scenario unfolds « Modèles à télécharger » first (#782) With the decider's key in `registry::PUBLIC_KEY` since #825, `registry_waits` was always false and « La liste ne peut pas encore être mise à jour : elle attend la clé qui la signe » never said: removed, with its flag, its field in both languages and its test. WITHOUT_COMMENT lowered to 596. list_refreshed now unfolds « Modèles à télécharger », folded since this pull request, before it reads and presses « Mettre à jour la liste ». Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * shell: e2e — W's stand-in says it closes each connection, so that the signature is never asked on a closed one (#866) At d5875b4, W alone failed its last read once: the shell logged « the list's signature could not be read (io: Peer disconnected) », the signature's request never reaching the stand-in. It answers in HTTP/1.0, closing each connection without saying so, and the client may send the next request on the one just closed. It now says « Connection: close ». Main's run of W alone was green: a race. Agent-Session: 04463b35-db3b-47ea-bef5-6892f2baedb7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: kitokey-lina[bot] <356214857+kitokey-lina[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D56 — shell: the list of models read again is taken only signed by the decider's key, now built in
Taken up from #643, by dime-hermes, credited as co-author of each commit. This pull request is #643's shell part only. Its capture part is in #787. Its platform part (
onnxruntime <1.24) is left out: no need for it has been shown.Module
modules/shell— exactly one.cross-modulelabel is required, justification belowDeliverable
Out of cycle: D56 is not among cycle 10's deliverables (D92 to D95). It is in cycle 10's What needs a person, which waited on the decider's key. The decider made that key on 2026-11-14, in their own terminal. The key an agent made on 2026-11-05 for #643 is dropped and appears nowhere here.
D56's criteria, from cycle 09:
main: ADR-0010, Amended by D56.What it changes
The key.
registry::PUBLIC_KEYis set to the decider's public key,minisign public key 28AD0E835D7AF31E. Its file,registry/kitokey-models.pub, sits beside the list. Both are public.The signature.
registry/models.json.minisigis the decider's signature ofmodels.jsonas it is onmainat 1d6ee69 (sha2561627839e…046b). The coordinator checked it withminisign -Vm … -p kitokey-models.pub: « Signature and comment signature verified ».registry/.gitattributes(* -text) keeps both files' bytes as signed.No new code path. The verifying (
registry::verify,minisign-verify), the refusals and the repository's check were already onmain, waiting on the key. With the key built in:the_list_in_the_repository_verifies…now verifies the list in the repository against the key, in every pull request.Who signs. The decider alone, in their own terminal.
AGENTS.mdnow says it in the list's paragraph: a change tomodels.jsonis signed again by the decider (minisign -Sm modules/shell/registry/models.json) and its.minisigcommitted with it. An agent never holds, makes or asks for the private key, and never signs. Until the decider has signed it, the shell's tests refuse a change to the list.README.mdnames the key built in.The e2e's scenario W read « the list waits on the key ». It now reads the list again through the window, served on this machine:
The shipped models stay offered throughout.
Oracle
tests/registry_fetch.rs(75e78d4), underregistry::PUBLIC_KEYitself:the_key_built_in_is_the_deciders: the key's number is28AD0E835D7AF31E.under_the_key_built_in_a_list_signed_by_another_key_changed_after_it_was_signed_or_unsigned_is_refused. Each case is refused for its signature, never for a key that is missing, and after both files are asked for:under_the_key_built_in_the_list_the_decider_signed_is_taken: main's list, with the decider's signature, is taken whole.PUBLIC_KEY = None, 75e78d4'sregistry.rs), all three failed.Err("the list is not read again: it waits on the decider's key").cargo test --test registry_fetch: 14 passed, with « registry/models.json: its signature verifies against the key built in ».a_list_signed_in_minisigns_legacy_form_is_refused.verifypassesLEGACY_ALLOWED,false, named. The test's key was made outside it (openssl's Ed25519, minisign's boxes, its private key not kept), because theminisigncrate writes the pre-hashed form only. The same bytes are signed both ways: pre-hashed, verified; legacy, refused. Withtruepassed, the test fails.Kind of oracle: unit tests on a server played on this machine, and the e2e's W through the window.
Review budget
Contracts
Definition of Done
Oracle green
Lint, format, types:
cargo fmt --check,cargo clippy --all-targets -D warnings,python3 -m py_compile scripts/e2e_window.py; ruffF,PLW2901finds nothing new in W (the findings left are shell: the e2e scripts pass ruff's F and PLW2901, before the hook that holds them to it #820's)Unit tests: as above. Two mutants of
src/registry.rs, each applied alone (git diff --numstat) then restored, were both killed:fetchnot verifying the signature: the refusal tests failed, the test key's and the decider's;PUBLIC_KEY: the key's number, the repository's check and the decider's list taken all failed.The shell's whole suite passes except
tests/migrate.rs::a_model_written_from_home_is_named_where_it_went. That test writes in$HOME, which this sandbox refuses; it fails the same way onmain, and shell: the test of a model written from the home uses a home of its own #819 fixes it.E2E on critical journeys: W, the coordinator's run
Affected documentation updated:
AGENTS.md(who signs, and how) andREADME.md(the key built in). ADR-0010 already records D56.Diff self-reviewed line by line
Test sheet
Verifier: session bfdb23f1-1199-4cda-ab11-22e178326643
28AD0E835D7AF31E, and the list in the repository verifies under itcargo test --locked --test registry_fetchat 788584f, run by me: 14 passed,the_key_built_in_is_the_decidersok, and « registry/models.json: its signature verifies against the key built in ».minisign -Vm models.json -p kitokey-models.pub: « Signature and comment signature verified »;models.jsonsha2561627839e…046b; key id read from the.puband the.minisig:28AD0E835D7AF31Eboth. Hand mutant,models.jsonchanged by one space: 3 tests failed, killed. Run again by me at 788584f (main merged in again):registry_fetch14 passed; the mutants and probes above were run at 044856c,src/registry.rsand the registry's files unchanged since.788584funder_the_key_built_in_a_list_signed_by_another_key_changed_after_it_was_signed_or_unsigned_is_refusedok at 788584f. Hand mutants:verifyalwaysOk→ 4 failed, killed;fetchignoringverify→ 2 failed, killed. My probes under the key built in, a list served here: a test key's signature with the decider's key id written in, the trusted comment changed, the list in CRLF, with a BOM, or one line feed more → each refused, « the list's signature does not verify (The signature verification failed) ». Run again by me at 788584f (main merged in again):registry_fetch14 passed; the mutants and probes above were run at 044856c,src/registry.rsand the registry's files unchanged since.788584funder_the_key_built_in_the_list_the_decider_signed_is_takenok at 788584f; my probe: main's list withmodels.json.minisig, served here →Ok, 2 models. Run again by me at 788584f (main merged in again):registry_fetch14 passed; the mutants and probes above were run at 044856c,src/registry.rsand the registry's files unchanged since.788584fevidence-825/e2e.txt,audit.jsoncommit 788584f, verdict passed; 1825ok, 0FAIL, « e2e: passed »; read by me), W: « the key built in: a button offers to read the list again, its host shown, nothing said of a key awaited », « a list unsigned: refused, said, the models shipped still offered », « a list changed after the decider signed it: refused, said, the models shipped still offered », « a list its signature none: refused, said, the models shipped still offered », « the list the decider signed: taken, nothing said against it, its models offered » — eachok.788584fRWS44…) is nowheregit grep -IE 'RWQAAEIy|RWRTY0Iy|RWS44|PRIVATE KEY'(minisign's secret-key prefixes, unencrypted and encrypted) → nothing; no.key,.secor.pemfile;git log -S RWS44over main at 065c769, this head 788584f and the workspace's branches → no commit. The test key is made in memory each run, never written; the legacy fixture holds a public key and two signatures only. Searched again at 788584f: the same, nothing.788584fa_list_signed_in_minisigns_legacy_form_is_refusedok at 788584f (14 passed): the same key and bytes,EDpre-hashed →Ok,Edlegacy → refused, and refused byin_the_repository. Hand mutantLEGACY_ALLOWED = true→ that test failed, killed: the legacy fixture is a valid signature, refused for its form alone. Run again by me at 788584f (main merged in again):registry_fetch14 passed; the mutants and probes above were run at 044856c,src/registry.rsand the registry's files unchanged since.788584fregistry/models.json, when the shell's tests run, then a list whose signature does not verify against the key built in — unsigned, signed by another key, or changed after it was signed — is refused (D56, criterion 2):the_list_in_the_repository_verifies_or_waits_on_the_key_and_the_check_says_whichon the list in the tree,the_check_of_the_list_in_the_repository_refuses_a_signature_that_does_not_verify_once_a_key_is_built_inon the three refusalscargo test --locked --test registry_fetchat 788584f, run by me: 14 passed —the_list_in_the_repository_verifies_or_waits_on_the_key_and_the_check_says_which(the list in the repository, « its signature verifies against the key built in ») andthe_check_of_the_list_in_the_repository_refuses_a_signature_that_does_not_verify_once_a_key_is_built_in(unsigned, another key's, changed after signing: each refused). Hand mutant at 788584f,registry/models.jsonchanged by one space after the decider signed it:the_list_in_the_repository_verifies…and two others FAIL, 11 passed — a pull request that changes the list without signing it again is refused.788584fVerifier's remarks: S2's « signed by another key » carries that key's own number, so it is refused at the key id before any curve: my P1 probe holds the forged one with the decider's number. The trusted comment (
timestamp,file) is verified, never read: an older list the decider signed would be taken again — a rollback, followed in #826. D56's criterion 2 is now S7. W's « taken » is seen only as no refusal said: the list served is the shipped one, so the page draws the same models either way.Summary
DONE
registry::PUBLIC_KEYis the decider's key. Their signature of the list and their public key's file sit beside the list.AGENTS.mdsays that the decider alone signs the list, in their own terminal.VERIFIED
truepassed.tests/registry.rs: 6 passed. fmt, clippy andpy_compile; the pre-commit hooks.main.main(36f9754) merged in: the full shell e2e green, scenario W among it; ines's sheet.ASSUMED
raw.githubusercontent.com/NapkinStack/wholeheard/…(registry::ADDRESS, the name before D86) still answers. On 2026-11-14 it answered 200, as did…/kitokey/…. A follow-up may namekitokey; it is left as it is here (minimum).NOT VERIFIED
under_the_key_built_in_the_list_the_decider_signed_is_takenchecks the list taken whole.mainitself, once this merges: the same bytes and signature as in S3, so only the forge's answer differs.RISKS
models.jsonneeds the decider's new signature in the same pull request, or the shell's tests are red, by design.offered_refresh_waitsand Settings' « waits » branch are now reached by no build. They are left as they are, for a build without a key.Signals to report
🤖 Generated with Claude Code