Repository navigation
One lighter scrim for ConfirmDialog and Drawer - #134
Merged
Merged
Conversation
Contributor
Author
QA Review: PR #134Scope: 5 files, +47/−4 · worktree: supplied review worktree; creation and dependency installation skipped as requested · reviewed: 2888606 · CI: green Critical (must fix)None. Fix in-PR (apply mechanically — no adjudication essay expected)None. Suggestions (optional)None. What Looks Good
Body claims
machine record{
"kind": "review",
"pr": 134,
"round": 1,
"reviewed": "2888606952c12b1cd2f32bbe436c3fcdd31283de",
"delta_base": null,
"ci": "green",
"risk": "LOW",
"stop_gate": "n/a",
"verdict": "No findings; eligible for qa-reviewed.",
"label": "eligible-on-green",
"findings": []
} |
# Conflicts: # CHANGELOG.md
Contributor
Author
QA Review: PR #134Scope: Delta: 11 files, +65/−25; branch against origin/main: 5 files, +47/−4 · supplied review worktree; creation and dependency installation skipped · reviewed: 9264277 · CI: green Critical (must fix)None. Fix in-PR (apply mechanically — no adjudication essay expected)None. Suggestions (optional)None. What Looks Good
Body claimsNot re-audited in round 2, per the delta-review scope. machine record{
"kind": "review",
"pr": 134,
"round": 2,
"reviewed": "92642775c116e34153ac8cdb50316a7a06f193cd",
"delta_base": "2888606952c12b1cd2f32bbe436c3fcdd31283de",
"ci": "green",
"risk": "LOW",
"stop_gate": "ship-the-core",
"verdict": "SHIP THE CORE — no findings.",
"label": "eligible-on-green",
"findings": []
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A kit overlay's scrim can only cover the app's frame, never the host chrome around it. At 0.4 (dialog) and 0.32 (drawer), the frame's edge read as a break in the page while an overlay was open. Both now use one constant,
SCRIM_BACKGROUND(rgba(0, 0, 0, 0.2)) ininternal/top-layer.ts; the panel's border and shadow carry the separation.npm run cigreen (657 tests); the vendored IIFE is unchanged (the UI kit is not in that bundle).