Repository navigation
fix(privacy): align PII scrub copy with Presidio state and expose Solo audit log - #167
Conversation
…o audit log - Branch the 'Scrub personal details before training' description in personalize.html on presidio_available() so base installs without the privacy pack state that emails, phone numbers, and IDs are removed while names and places require the privacy pack (#155). - Pass presidio_available() and scrub_coverage() in personalize_get() and settings_post(), and drop the duplicated trailing caveat in settings.html (#155). - Link /audit from the Solo dashboard 'Your workspace' card and the Settings -> Privacy tab, and append UTC to event timestamps in audit.html (#156). Closes #155 Closes #156 Spec: docs/specs/privacy-pack-and-scrub-transparency.md Agent: Antigravity (automated, instructed-by: ramedey) Signed-off-by: Raul Amedey Ciria <raul.amedey@rentslam.com>
|
ASDD review - advisory (recommendation:
The PR correctly implements the requested UI updates for PII scrub transparency and audit log accessibility for Solo users. It aligns the copy in CODE - okNo findings. SECURITY - ok
SPEC - okNo findings. QUALITY - okNo findings. QUALITY - ok
Generated by the ASDD advisory review. Mode: |
Documentation agent - proposed doc updates for PR #167 (
|
Test agent - result for
|
Lane (required)
pillar:privacySpec (required for non-
chore)docs/specs/privacy-pack-and-scrub-transparency.mdWhat & why
Closes #155
Closes #156
personalize.htmlhardcoded"Removes names, emails and IDs first."under Scrub personal details before training even whenpresidio_available()wasFalse(base install without the privacy pack), contradictingscrub_coverage()and/settings. Meanwhile,settings.htmlrepeated the "not redacted" caveat twice in one line./auditfrom either the dashboard or Settings -> Privacy, andaudit.htmlrendered UTC event timestamps without a timezone label.How
anthill/web/app.py: passpresidio_available()intopersonalize_get()and passscrub_coverage()/presidio_available()/privacy_pack_can_install/privacy_installingintosettings_post().anthill/web/templates/personalize.html: branch the Scrub personal details before training description onpresidio_available()(with anInstalllink to/settingsfor admins when absent) and add a direct link to/auditin the Privacy tab footer.anthill/web/templates/settings.html: drop the duplicated trailing clauses after{{ scrub_coverage }}.anthill/web/templates/dashboard.html: add/auditlink to the Solo Your workspace card.anthill/web/templates/audit.html: appendUTCto event timestamps.tests/test_privacy_pack_web.py,docs/specs/privacy-pack-and-scrub-transparency.md,changelog.d/155.fixed.md,changelog.d/156.fixed.md: update spec, add regression tests, and record changelog fragments.Disclosure (required - ASDD)
carries the
Agent:trailer).wrote it). Disclosure is attribution; this is accountability.
Checklist
git commit -s; intake checks the full PR range.make testis green.docs/specs/privacy-pack-and-scrub-transparency.md,changelog.d/155.fixed.md,changelog.d/156.fixed.md).