Validate VAAPI color profiles on the selected decode device - #962
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Probe HEVC and AV1 support separately for 8-bit and 10-bit 4:2:0. Use the appropriate VAAPI profile and render-target format instead of treating a 10-bit probe as proof of every color mode. Bind FFmpeg to a render node that supports the requested profile, while preserving the existing H.264 route.
Keep each render-node file descriptor alive through
vaTerminate. Report decoded Linux color-format changes through the existing media feedback contract, including planar I420, without guessing a YUV color class from RGB output.Verification
Independently reviewed the final capability, device-selection, descriptor-lifetime, and feedback changes. The feature-enabled native streamer workspace passed, including 123 Linux platform tests and 145 platform tests. Workspace formatting and locked Clippy with warnings denied also passed.
Focused regressions cover HEVC Main versus Main10, AV1 Profile0 with distinct render-target formats, device selection, descriptor lifetime during termination, H.264 policy preservation, and decoded-format feedback.
Limits
No real VAAPI GPU or live GeForce NOW session was available. Tests verify profile queries, policy, ownership, and feedback; they do not establish hardware decode performance or optical HDR output.