Skip to content

Carry validated output luminance into HDR session requests - #964

Merged
capy-ai[bot] merged 2 commits into
devfrom
capy/carry-validated-hdr-display
Sep 16, 2026
Merged

capy-ai[bot] merged 2 commits into
devfrom
capy/carry-validated-hdr-display

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Changes

Stacked on #962. This PR contains only the HDR display-metadata layer.

Carry the current Wayland output's validated target luminance through HdrOutput, CoreClient, and the native core into CloudMatch HDR monitor requests. Keep the documented requested-content defaults when the output has no validated snapshot.

Discard stale snapshots after display changes and strip caller-supplied values when Qt has no current output metadata. Treat the snapshot as transient runtime data: reject settings writes and remove persisted copies. Do not invent display primaries or a sustained full-frame luminance value for the vendor payload.

Verification

Independently reviewed the final propagation and invalidation paths. After stacking on the exact reviewed #962 commit:

  • Core and streamer formatting checks passed.
  • Locked core Clippy passed with warnings denied.
  • The full core suite passed, including 363 main tests and 31 library tests.
  • The Qt application and tests built successfully.
  • Five focused HDR and CoreClient tests passed.
  • All 337 Qt tests passed in a complete rerun after a machine restart interrupted the first attempt.

Regression coverage includes output metadata changes, malformed ranges, stale caller snapshots, settings persistence, and unavailable-output fallback.

Limits

No HDR-capable Wayland compositor, physical display, VAAPI GPU, or live GeForce NOW account was available. These checks establish metadata validation and request propagation, not optical calibration or live HDR output.

Open in Capy

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 7a9ff373-7aa6-4321-bdba-29f1d5b4a655

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 2 other findings in Capy.

Open in Capy

@capy-ai
capy-ai Bot changed the base branch from capy/validate-vaapi-color-profiles to dev September 16, 2026 07:18
@capy-ai
capy-ai Bot merged commit d7e1fbb into dev Sep 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant