Carry validated output luminance into HDR session requests - #964
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 15, 2026
capy-ai
Bot
changed the base branch from
capy/validate-vaapi-color-profiles
to
dev
September 16, 2026 07:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stacked on #962. This PR contains only the HDR display-metadata layer.
Carry the current Wayland output's validated target luminance through
HdrOutput,CoreClient, and the native core into CloudMatch HDR monitor requests. Keep the documented requested-content defaults when the output has no validated snapshot.Discard stale snapshots after display changes and strip caller-supplied values when Qt has no current output metadata. Treat the snapshot as transient runtime data: reject settings writes and remove persisted copies. Do not invent display primaries or a sustained full-frame luminance value for the vendor payload.
Verification
Independently reviewed the final propagation and invalidation paths. After stacking on the exact reviewed #962 commit:
Regression coverage includes output metadata changes, malformed ranges, stale caller snapshots, settings persistence, and unavailable-output fallback.
Limits
No HDR-capable Wayland compositor, physical display, VAAPI GPU, or live GeForce NOW account was available. These checks establish metadata validation and request propagation, not optical calibration or live HDR output.