Gate 360 FPS on entitlement and the effective hardware decoder - #968
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
This was referenced Sep 16, 2026
capy-ai
Bot
changed the base branch from
capy/select-embedded-software-decode
to
dev
September 16, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stacked on #967, which depends on #964 and requires #961 before landing.
Offer 360 FPS at the documented 1920x1080 and 1920x1200 resolutions only when membership and the selected codec's hardware decoder are confirmed. Keep unavailable rates visible but disabled across desktop, console, and onboarding. Preserve a saved preference while capability results are still unknown; downgrade it only when a known constraint requires that.
Use the software-decode parent's backend resolver so the legacy software preference cannot qualify as hardware. Carry the selected rate through session creation, NVST negotiation, and platform frame-duration validation without the old 240 FPS clamp.
Independent verification
The final 20-file tree was independently inspected and checked against its exact checkpoint before publication.
Rendered acceptance fixtures were inspected for desktop, device-locked desktop, console, and onboarding. Coverage includes entitlement changes, unavailable or delayed capabilities, resolution changes, and the legacy software-backend interaction.
Limits
No entitled live account or 360 FPS gameplay session was available. Screenshots and entitlement responses are explicit acceptance fixtures. The macOS-specific duration change was inspected but cannot be exercised on this Linux machine. Final combined-stack checks remain required before the program's ordered merges.