Repository navigation
SCANFI v2: LandR supplies the arbutus mirror remap locally; current host; ageURL fix - #274
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
added
enhancement
…V2 land cover from the manifest Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ror remap locally per download Reverts the switch to arbutus urls at the call sites. The default remap (current host object-arbutus.alliancecan.ca) is applied only around SCANFI downloads when the user has set no reproducible.urlRemap; .onLoad() no longer sets the global option. A supplied ageURL is respected; access messages name the Arbutus mirror for remapped V2 ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
changed the title
eliotmcintire
added a commit
that referenced
this pull request
Oct 15, 2026
SCANFI v2: LandR supplies the arbutus mirror remap locally; current host; ageURL fix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The message decided "Drive or mirror" from the options alone, so a user with their own reproducible.urlRemap was told to check that urlRemap is non-NULL (it was) and to enable LandR.scanfiMirror (it was). It now reads the error: a Google Drive error is a Drive access problem, otherwise a remapped V2 url is a mirror (network) problem. The mirror advice names the setting that applies, and the message is about half as long. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shorter SCANFI download errors that name the server that failed
eliotmcintire
added a commit
that referenced
this pull request
Oct 16, 2026
Brings in #276: shorter SCANFI access errors that name the server that failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # NEWS.md
NEWS: keep both new entries (SCANFI remap; prepInputsFireYear latestYear). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011oFSqD7YBJZdkFfStooVtz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCANFI v2 maps still download by their Google Drive ids, and LandR now redirects those ids to the PredictiveEcology mirror by itself, only while a SCANFI download runs. The mirror address in the shipped list was out of date and is fixed, and a stand-age URL you pass is no longer thrown away.
Affects: SCANFI v2 downloads need no Google sign-in and no
reproducible.urlRemapoption, LandR no longer sets that option when it loads, and a remap you set yourself always wins.Technical details
Defects:
inst/extdata/arbutus_manifest_SCANFI_v2.csvpointed atobject-arbutus.cloud.computecanada.ca, which returns NoSuchBucket for every SCANFI path (the current host isobject-arbutus.alliancecan.ca);R/prepInputObjects.R(prepInputsStandAgeMap, the V1 and V2ageURL <-assignments) overwrote a suppliedageURLalthough the error text told users to pass it.Fix: Drive ids stay the addresses at every call site.
.withScanfiRemap()(R/scanfiMirror.R) setsreproducible.urlRemaptoscanfiUrlRemap()for the length of one SCANFI download, only when the user has set none andLandR.scanfiMirroris not FALSE, and restores it on exit; it is applied in.withSCANFIAccess()and aroundprepInputs_SCANFI_structure(). It replaces.setScanfiMirror()in.onLoad(), so the global option is never set and other packages are unaffected; this changes load-time behaviour, so say if you want the global set back. Access errors name the Arbutus mirror for V2 ids that will be remapped and keep the restricted-folder text for V1, user Drive urls and users with their own remap.Tests (
test-scanfiMirror.R): manifest host, default applied only inside the call and not left behind (also after an error), user remap wins, switch-off, a mockedprepInputssees the remap and the global stays NULL, suppliedageURLreachesprepInputsfor V1 and V2, message wording. Full suite: 221 tests, 0 failed, 21 skipped (base: 215, 0, 21).R CMD check --no-manual --no-tests --no-build-vignettes: no Rd or codoc warnings (the vignette warnings come from skipping the build).🤖 Generated with Claude Code