defaultFireYears() starts in 1986

[eliotmcintire]

The default fire years now start in 1986, one year after the first vegetation year, because each year's fires are now fitted against vegetation from an earlier year. Fires of 1985 can no longer be paired with any vegetation.

Affects: the default fire years of fireSense_dataPrepFit and fireSense_ELFs (ELF fire counts for merging now exclude 1985).

Technical details

Defect: defaultFireYears() (R/defaultFireYears.R:15) returned 1985L:climateData::latestHistoricalYear(). SCANFI vegetation of year Y already shows year Y's burns, so fireSense_dataPrepFit#73 pairs each fire year with the latest data year strictly before it, and 1985 has none. Fix: it returns 1986L:...; roxygen and man/ updated. Other uses (R/fireSenseCloudParameterStatus.R:120, plotELFs()) call the function and need no change; the 1985 in ledger file names and dataYears examples is unrelated. test-defaultFireYears.R now expects 1986 (fails on the old code: 2 failures). R CMD check (--no-manual, suggested packages PtProcess, spatstat, spelling not installed so _R_CHECK_FORCE_SUGGESTS_=false, scratch library phase4/lib): 0 errors, 0 warnings, 0 notes; tests 0 failed, 1979 passed, 10 skipped. Base (development): 0 failed, 1994 passed, 2 skipped (devtools::test).

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (7cc9645) to head (19e0b15).

Additional details and impacted files

@@             Coverage Diff              @@
##           development     #158   +/-   ##
============================================
  Coverage        89.13%   89.13%           
============================================
  Files               50       50           
  Lines             4398     4398           
============================================
  Hits              3920     3920           
  Misses             478      478           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.