Repository navigation
fireYears default is plain defaultFireYears() - #74
Merged
Merged
Conversation
….2.3.9099 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eliotmcintire
added a commit
that referenced
this pull request
Oct 16, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fire years this module fits now come straight from the shared default, which starts in 1986, instead of dropping the first year here. The default years themselves do not change.
Affects: nothing in the default fire years (still 1986 on); the module now needs the newer fireSenseUtils.
Depends-on: PredictiveEcology/fireSenseUtils#158
Technical details
fireSense_dataPrepFit.R:56 defaulted
fireYearstofireSenseUtils::defaultFireYears()[-1L]because fireSenseUtils' default started in 1985 (set in #73). fireSenseUtils#158 makesdefaultFireYears()start in 1986, so the default is now the plain call and thefireSenseUtilsfloor is 0.2.3.9099 (the version development will have after #158 merges). test-fireYearsDefault.R now expects the plain call. Module suite viaconvertToPackage()+test_local()with #158 installed (as 0.2.3.9099) in a scratch library: branch 0 failed, 320 passed, 1 skipped; development (unchanged module, still[-1L], so it starts in 1987 with #158) 1 failed (the first-fire-year expectation), 319 passed, 1 skipped.🤖 Generated with Claude Code