Compiler: extract ByRefFormalAssignAndCallArgAdapt from JIT.php (#36387) - #36787
Merged
Merged
Conversation
Move-only Concern split (bindJitParamByReference → ensureValueBoxLvalueForByRefPass) toward gen-0 split-TU / size-budget ratchet; SPINE_CHUNK demote + inventory sync. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bindJitParamByReference→ensureValueBoxLvalueForByRefPass) fromlib/JIT.phpintolib/JIT/Concern/ByRefFormalAssignAndCallArgAdapt.php(Part of Performance: compile-time targets and gate — hello-world ≤ 3 s warm, MiniWebApp ≤ 10 s, 400 statements per function in < 5 s, one-file edit rebuild < 25 % of full, spine gen-0 < 30 min with split-TU (script/bench-gate.php --compile, bin/compile.php, lib/Compiler.php) (re-#36224 slice 2, re-#36199) #36387).lib/JIT.php13959 → 13337; spine 8216/8216; SPINE_CHUNK demote for the new Concern; size-budget + bootstrap-inventory sync.php-src:
Zend/zend_execute.cZEND_SEND_REF/ZEND_RECV/zend_assign_to_variable— move-only Concern extract; no new C ABI / IR shape change.Closes nothing (Part of #36387).
Test plan
php -l lib/JIT.php+lib/JIT/Concern/ByRefFormalAssignAndCallArgAdapt.php./script/check-size-budgets.shOKphp script/check-selfhost-spine-coverage-sync.phpOK (8216)php script/bootstrap-inventory.php --checkOK 8216/8216./script/phpunit.sh --filter 'SpineChunkRuntimeMethodDemoteTest|BootstrapSelfhostBundleTest::testCompilerLibSpineSmokeBundleUsesRequireOnce'→ 3/3./script/aot-smoke.sh→ 9/9 + size gate OKmake north-star5-verify-fast→ OKphp script/opcode-corpus-md5.php --check→ OK (move-only)Not run:
--strict, fullscript/differential-sweep.sh --aot(move-only extract).Made with Cursor