Repository navigation
ci: the release PR scope check accepts metadata without an observability version example - #792
Merged
Merged
Conversation
…ity version example
github-actions
Bot
added
size/S
Contributor
PR Quality ReportCompared against base branch Coverage and tests
Compatibility
Performance smokePerformance smoke was skipped for this PR because no perf-sensitive paths changed. State
|
szibis
added a commit
that referenced
this pull request
Oct 21, 2026
…ased (#793) #792 merged before the v2.24.0 metadata pull request (#791), and the squash merge of #791 placed #792's entry inside the released 2.24.0 section, which v2.24.0 never contained. Restore 2.24.0 to what the release published and list the entry under Unreleased, where the next release picks it up. Co-authored-by: szibis <szibis@users.noreply.github.com>
szibis
added a commit
that referenced
this pull request
Oct 21, 2026
The release workflow could not create the metadata branch for v2.24.1 (it was cut from #794 while main had already moved on). Materialize the published 2.24.1 notes as the [2.24.1] section (#792's CI entry and #794's Security entry, exactly as released) and set the chart to 2.24.1; [Unreleased] keeps the entries merged since (#795, #796, #797). Co-authored-by: szibis <szibis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first bot-opened metadata pull request (#791, v2.24.0) failed
release-pr-scopewithdocs/observability.md service.version example is not 2.24.0.docs/observability.mdhas had no"service.version"example since #109, sosync_release_metadata.sh's substitution for it changes nothing and the check (carried over from the old dispatch-only validation) could never pass. #791 itself is correct: it changes onlyCHANGELOG.mdandcharts/loki-vl-proxy/Chart.yaml, one GitHub-verified commit.Change
.github/workflows/release-pr-validation.yaml: the observability check runs only whendocs/observability.mdat the pull request's head contains a"service.version"key; when it does, the first entry must equal the release version (a key without a string value fails). The Chart.yaml and CHANGELOG checks stay unconditional (the sync script always rewrites them).sync_release_metadata.shis unchanged.Proofs
scripts/ci/tests/test_release_pr_validation.py: 4 new cases, 77 script tests pass — no example passes; a stale example fails; a key without a value fails; an exact replay of #791 (CHANGELOG + Chart.yaml, verified commit, no example) passes. actionlint (pinned and local), zizmor 1.30.1 (pinned, no findings), conformance and changelog gates.Merge after #791: a push to main before #791's release metadata merges would make the release bot cut a duplicate release. After this lands, re-running
release-pr-scopeon any open metadata PR passes.Follow-up, not in this change: the dead
service.versionsubstitution inscripts/ci/sync_release_metadata.sh.