Repository navigation
feat: add in-game replay controls - #45
Merged
Merged
Conversation
Alexbeav
marked this pull request as ready for review
November 4, 2026 09:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an in-game Replays page beside F7 save states. F11 starts/stops recording from a restored mid-game anchor; a red dot and REC label appear only after runner confirmation. The replay browser uses the same rounded thumbnail cards as save states, with clearly labeled active tabs, page headings and a persistent left-rail marker. Selecting a card opens Play, Export copy and confirmed Delete. Recording shortcuts remain rebindable; fullscreen moves to Alt+Enter.
Play starts a fresh runner process with the selected movie. After neutral controls, a button or stick takes over the same running game. Successful verification has a normal completion screen; refusals and saved/failed recording status remain visible. Playback save memory stays private.
Pins the companion Runtime commit for link 2.5 controls, anchored movies and verification. Optional private preview sidecars capture the current displayed frame before recording starts, retain its aspect and store title/date/frame-rate metadata. Checksums and the movie seal bind previews to their recording. Old movies stay visible without modification; missing or corrupt previews show a placeholder. The scrolling grid retains every recording, including history beyond twelve cards.
Validation: frontend builds successfully; all 43 windowless frontend/runtime tests pass, including recording hotkey persistence, anchored start/stop, selected-replay process restart and existing replay protection. The preview test captures pixels produced by the test core through CoreLink and checks byte-identical metadata persistence, corrupt/oversized/missing-preview fallback, 18-record history and page switching. Real Smash gameplay recorded 200 fields and matched every state/picture/audio checkpoint in fresh headless and linked processes. Live input at field 40 took over and continued to 250 with zero faults.
Core limitation: the older shipped Smash core fails anchored replay; the tested core contains the current file-state fixes (source 6b10cf4), using Fast CPU, HLE graphics/audio, software 1x and async off. No checkpoints were weakened. The owner accepted the revised page and card layout. Physical controller use and audio-device output remain untested; the GL picture test was excluded to keep automated validation headless.
Depends on RetroPortingToolKit/Retro-Runtime#10.