Repository navigation
feat: record and verify input replays - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds shared input recording and fresh-process verification for headless and linked core sessions. Records the inputs delivered to the core, clocks, initial saves and exact component/configuration identities. Each field checks available state, CPU pictures and audio; malformed or mismatched movies refuse with a machine-readable verdict.
Link 2.5 adds anchored start/stop recording and authoritative recording/playback status for the frontend. Mid-game recording saves and restores an anchor before accepting inputs. Playback uses private save memory and supports neutral-armed live-input takeover without resetting the core. Boot movies remain readable.
Validation: all 38 Runtime tests pass within the combined 42-test frontend/runtime headless run. New coverage includes anchored recording, selected-replay process restart, existing-file protection, input authority, completion, takeover, identity and checkpoint failures, and interrupted recording recovery. A real Smash gameplay anchor recorded 200 fields and matched every state/picture/audio checkpoint in fresh headless and linked processes. Takeover at field 40 continued to 250 with zero faults.
Core limitation: the older shipped Smash core fails anchored replay; the tested core includes the current file-state fixes (source 6b10cf4), with Fast CPU, HLE graphics/audio, software 1x and async off. No checkpoints were weakened. GPU presentation, physical controllers and audio-device output were not tested. The owner accepted the companion frontend's revised page and card layout. The GL picture test was excluded to keep validation headless.
Companion frontend: RetroPortingToolKit/Retro-Launcher#45 adds the F7 replay browser, F11 recording and REC indicator.