Repository navigation
fix(comms): resolve update_members channel by name for agent tools (RIG-3030) - #1588
Merged
trunk-io[bot] merged 2 commits intoOct 4, 2026
Merged
Conversation
…IG-3030) Agent tools address channels by name only. UpdateChannelMembersAsAccount now resolves channel_id with ChannelByNameForViewer within the caller's visible set before the id-typed handler, matching post and list. Unknown or invisible names return NOT_FOUND, ambiguous names INVALID_ARGUMENT, and there is no home default. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
😎 Merged successfully - details. |
|
Compass engineering docs preview: https://compass-server-rig-3030-upda.compass-eng-docs.pages.dev Deployed from |
…me-typed arms (RIG-3030) Co-authored-by: Matt Wilkinson <matt@rigel.build>
mattwilkinsonn
approved these changes
Oct 4, 2026
trunk-io
Bot
deleted the
compass-server/rig-3030-update-members-by-name
branch
October 4, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainAgent tools address channels by name only. UpdateChannelMembersAsAccount now resolves channel_id with ChannelByNameForViewer within the caller's visible set before the id-typed handler, matching post and list. Unknown or invisible names return NOT_FOUND, ambiguous names INVALID_ARGUMENT, and there is no home default.
Co-authored-by: Matt Wilkinson matt@rigel.build