Repository navigation
feat(store): unique sibling channel-group names with a repairing migration (RIG-3030) - #1595
Open
rigel-mintaka wants to merge 9 commits into
Open
rigel-mintaka wants to merge 9 commits into
rigel-mintaka wants to merge 9 commits into
Conversation
|
Compass engineering docs preview: https://compass-server-rig-3030-grou.compass-eng-docs.pages.dev Deployed from Changed pages: |
Base automatically changed from
compass-server/rig-3030-update-members-by-name
to
main
October 4, 2026 14:08
|
❌ This pull request could not start testing because there was a merge conflict. See more details here.
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
rigel-mintaka
force-pushed
the
compass-server/rig-3030-group-refs-by-name
branch
2 times, most recently
from
October 5, 2026 18:19
cf19956 to
57bd360
Compare
rigel-mintaka
force-pushed
the
compass-server/rig-3030-group-refs-by-name
branch
from
October 6, 2026 05:08
81b184a to
d40ea59
Compare
rigel-mintaka
marked this pull request as ready for review
October 6, 2026 06:55
mattwilkinsonn
approved these changes
Oct 7, 2026
…ation (RIG-3030) Group names become unique among one owner's siblings and may not contain a slash, so a slash path from main's group-ref resolver names at most one of an owner's groups. The migration repairs existing rows as compass_system: slash names are rewritten, duplicates get a free -N suffix with the pre-existing valid name kept, and reserved top-level groups are untouched. CreateChannelGroup maps the new unique violation to AlreadyExists. Co-authored-by: Matt Wilkinson <matt@rigel.build>
…d reserved names (RIG-3030) Co-authored-by: Matt Wilkinson <matt@rigel.build>
sqlc-vet replays migrations through autocommit psql, where a bare LOCK TABLE errors. Co-authored-by: Matt Wilkinson <matt@rigel.build>
…lify group refs (RIG-4458) A leading / anchors a ref at top level and /~handle/ picks the owner, so every visible group stays addressable while ambiguity still errors (DL-291). Co-authored-by: Matt Wilkinson <matt@rigel.build>
…line (RIG-3030) Co-authored-by: Matt Wilkinson <matt@rigel.build>
… old-binary inserts (RIG-4458) An agent-created owner group is visible to its user and sibling agents, matching the OWNER contract. A trigger fills namespace_owner_id for inserts that omit it. Co-authored-by: Matt Wilkinson <matt@rigel.build>
A shared group has no per-user namespaces, so a child name exists once under its parent whoever creates it. Top-level names stay per namespace. Co-authored-by: Matt Wilkinson <matt@rigel.build>
Co-authored-by: Matt Wilkinson <matt@rigel.build>
…G-3030) Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-server/rig-3030-group-refs-by-name
branch
from
October 7, 2026 03:37
89e1e5d to
ae8ae97
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Channel-group names cannot contain
/. A top-level name is unique per namespace, and a nested name is unique under its parent. So a slash path from main's group-ref resolver (#1705) names at most one group under a given parent.0002_channel_group_names.sqlrepairs existing rows ascompass_system:-Nsuffix, and the pre-existing valid name is kept;(namespace for top-level groups, parent, name)and a no-slash CHECK.CreateChannelGroupmaps the unique violation toAlreadyExists.History
This PR was re-sliced onto main. #1705 (RIG-4344) shipped agent group refs by leaf or slash path, which superseded this PR's resolver half (
ChannelGroupByNameForViewer,pickGroup, the group_id-as-name agent wiring). Only the constraint half remains, as one commit.Testing
TestCreateChannelGroupSiblingNamesUnique,TestCreateChannelGroupNestedNameUniquePerParent.Linear: RIG-3030
RIG-4458 (ruled A + K1)
namespace_owner_idcolumn (the agent's owner user) keys the sibling-name index. A trigger fills it for inserts that omit it, so older binaries keep working during a rolling deploy./anchors a ref at top level, and/~handle/qualifies the top-level owner. An ambiguous ref still returns invalid_argument (DL-291), and the error names a ref for each match.0002_channel_group_names.sqlon the collapsed baseline.RIG-4651 (ruled)
pub/infraexists once. A second create of the same name returnsAlreadyExists.Ledger-impact: none (implements the RIG-4458 and RIG-4651 rulings in the record's own terms; no DL row changes).