Repository navigation
fix(ui): chrome cleanup: drop ADE and usage bar, Session Log naming, pane edges, row re-measure (RIG-4771) - #1811
Merged
trunk-io[bot] merged 4 commits intoOct 8, 2026
Conversation
This was referenced Oct 6, 2026
Merged
rigel-mintaka
changed the base branch from
compass-ui/rig-4446-split-pane
to
compass-ux/4676-new-tab-fresh
October 6, 2026 23:46
rigel-mintaka
changed the title
|
Compass engineering docs preview: https://compass-ui-rig-4771-chrome-c.compass-eng-docs.pages.dev Deployed from Changed pages: |
rigel-mintaka
changed the base branch from
compass-ux/4676-new-tab-fresh
to
compass-ui/rig-4446-split-pane
October 7, 2026 00:10
rigel-mintaka
changed the base branch from
compass-ui/rig-4446-split-pane
to
compass-ux/4676-new-tab-fresh
October 7, 2026 00:10
rigel-mintaka
changed the base branch from
compass-ux/4676-new-tab-fresh
to
compass-ui/rig-4446-split-pane
October 7, 2026 00:25
rigel-mintaka
changed the base branch from
compass-ui/rig-4446-split-pane
to
compass-ux/4676-new-tab-fresh
October 7, 2026 00:26
mattwilkinsonn
added this pull request to stack #1838
October 7, 2026 00:43
rigel-mintaka
marked this pull request as ready for review
October 7, 2026 01:06
mattwilkinsonn
approved these changes
Oct 7, 2026
|
😎 Stack merged successfully - details. |
rigel-mintaka
force-pushed
the
compass-ui/rig-4771-chrome-cleanup
branch
from
October 7, 2026 05:47
6debb17 to
13c0794
Compare
rigel-mintaka
removed this pull request from stack #1838
October 7, 2026 05:50
rigel-mintaka
changed the base branch from
main
to
compass-ux/4773-bridge-toggle
October 7, 2026 05:50
rigel-mintaka
added this pull request to stack #1924
October 7, 2026 05:50
…pane edges, row re-measure (RIG-4771) Removes the ADE subtitle and the stub-only UsageBar (with STUB_USAGE and its test), renames the observation pane to Session Log in user-visible strings, strengthens the log-panel and right-sidebar edges to --cx-border-strong, and re-measures virtualized message rows when a scope switch reuses them, which caused uneven gaps between thread messages. Co-authored-by: Matt Wilkinson <matt@rigel.build>
…RIG-4771) Review follow-up: re-measuring a reused row left it cached under its old key too, so one node piled up under many keys. Also drops leftover usage-bar mentions from the shell spec and stylelint comment. Co-authored-by: Matt Wilkinson <matt@rigel.build>
… (RIG-4771) Co-authored-by: Matt Wilkinson <matt@rigel.build>
Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-ui/rig-4771-chrome-cleanup
branch
from
October 7, 2026 05:57
13c0794 to
6ae2e57
Compare
mattwilkinsonn
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chrome cleanup from the 10-06 dogfood review (RIG-4771, part of RIG-4770).
UsageBar,STUB_USAGE, theusagePcttest, the usage grid row and its CSS. It only ever rendered stub data, including the hardcoded "compass · main" text. The shell grid is nowtopbar/left main right. A real usage display is RIG-2873.aria-label, minimize/expand titles)..log-panel,aside.rightand the narrow-pane.log-paneltop edge use--cx-border-strong. The edges were already there with--cx-border, but that token is 70% panel over the raised background and did not show.MessageStreamrenders rows reconciled by index. After a topic switch, a reused row element showed a different message but kept its first measurement (the 96px estimate). Rows now re-measure when their virtualizer key changes, and drop the cache entry for the key they no longer show. A cold load was always fine, which is why one thread looked right and another didn't.Stack
Stacked on #1798 (top of the in-window tabs line), because the top bar here is the tab strip.
Tests
App.test.tsx: "the shell carries no ADE subtitle and no usage bar". Red before:Expected "Compass", Received "CompassADE".LogPanel.test.tsxempty-state test asserts the "Session Log" text and label. Red before: received "No session trace — this agent hasn't run yet."ChannelView.scroll.test.tsx: "switching scope re-measures reused rows so message spacing stays uniform". Red before: offsets[0, 96, 192], expected[0, 40, 200].ChannelView.scroll.test.tsx: "a reused row is cached only under the key it currently shows" (review follow-up). Red without the stale-key delete:Expected "d-0", Received "a-0".compass-ui:test: 1297 pass, 0 fail. Typecheck and biome clean.Visual baselines
Recaptured locally under DL-399, with each PNG inspected. The usage bar is gone and the topbar wordmark is shorter on every full-page shot. Changed (11):
agent,backlog,bridge-empty,bridge-prs,bridge,done,narrow-pane,right-sidebar,settings,split-view,topic-markdown. Like the rest of the tabs line, this needs #1644 merged first.Risks
--cx-border-strongedge is visible but subtle. If the panes still read as one surface, the next lever is the border token values, which the brand-parity design (RIG-4774) owns.