Repository navigation
fix(ui): keep the Bridge Issues/PRs toggle in place - #1812
Merged
Merged
Conversation
This was referenced Oct 6, 2026
rigel-mintaka
changed the title
|
Compass engineering docs preview: https://compass-ux-4773-bridge-toggl.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
marked this pull request as ready for review
October 7, 2026 00:11
mattwilkinsonn
approved these changes
Oct 7, 2026
An error occurred while trying to automatically change base from
compass-ux/4676-new-tab-fresh
to
compass-ux/4682-narrow-agent-view
October 7, 2026 04:16
rigel-mintaka
changed the base branch from
compass-ux/4676-new-tab-fresh
to
main
October 7, 2026 05:48
|
😎 This pull request was merged. |
rigel-mintaka
changed the base branch from
main
to
compass-ux/4676-new-tab-fresh
October 7, 2026 05:49
rigel-mintaka
changed the base branch from
compass-ux/4676-new-tab-fresh
to
main
October 7, 2026 05:50
rigel-mintaka
added this pull request to stack #1924
October 7, 2026 05:50
Both toolbar segs used `margin-left: auto`. The PRs tab unmounts the grouping seg, so the tab seg took the auto margin and slid 166px right, out from under the pointer. The tab seg now sits by the heading on both tabs; the grouping seg stays right-aligned. The PRs-board visual test now asserts the tab seg box is unchanged across the flip (red before the fix). bridge.png and bridge-prs.png are re-captured. Spec-impact: none Refs RIG-4773 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-ux/4773-bridge-toggle
branch
from
October 7, 2026 05:54
84b5b37 to
926b499
Compare
mattwilkinsonn
approved these changes
Oct 8, 2026
|
This pull request was merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
mainSummary
On the Bridge, the Issues/PRs toggle jumped 166px every time you clicked it, so the next click hit a different spot.
margin-left: auto. The PRs tab hides the Swimlanes/Status seg (by design), so the Issues/PRs seg took the auto margin and slid right. Clicking Issues brought the grouping seg back and the toggle slid left again.Verification
bridge — PRs boardvisual test now checks that the tab seg's box is the same before and after the PRs click. It fails with the fix disabled (x 570 → 736) and passes with it.bridge.pngandbridge-prs.png, because the toggle now renders next to the heading.visual-gate: 15 passed.compass-ui:testpasses 1294; the 4 env-secrecy tests fail only because a jj workspace has no.git.typecheck,stylelintanddev-smokepass. Biome reports only two existing complexity warnings inBridge.tsx.Risks
Low. This changes CSS for one element. The toggle now renders next to the heading rather than at the right edge.
Compatibility
No API or data change.
Documentation
None. The board-view design does not fix where the toggle sits.
Ledger-impact: none (layout fix; no design record touched)
Refs RIG-4773