Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified apps/ui/e2e/__screens__/bridge-prs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified apps/ui/e2e/__screens__/bridge.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 10 additions & 2 deletions apps/ui/e2e/visual-smoke.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,17 @@ test.describe("visual smoke — legacy-palette baseline", () => {
test("bridge — PRs board", async ({ page }) => {
await page.goto("/#/");
await page.locator(".bridge").waitFor({ state: "visible" });
// The PRs seg button (Bridge.tsx:154-158) — label "PRs · N", matched on
// its stable prefix so the live count doesn't perturb the selector.
// The tab seg must not move when the PRs tab hides the grouping seg, or
// the control slides out from under the pointer.
const tabSeg = page.locator('[aria-label="Board view"]');
const onIssues = await tabSeg.boundingBox();
// The PRs seg button — label "PRs · N", matched on its stable prefix so
// the live count doesn't perturb the selector.
await page.getByRole("button", { name: /^PRs/ }).click();
await page.locator('[aria-label="Board grouping"]').waitFor({
state: "detached",
});
expect(await tabSeg.boundingBox()).toEqual(onIssues);
// Wait on a populated PR card in the board (Bridge.tsx `.bridge-grid` >
// `.bridge-cell` > `.cx-card`), not the grid container — the grid renders
// even with no cards, so gating on a card guarantees the populated board is
Expand Down
6 changes: 6 additions & 0 deletions apps/ui/src/app.css
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,12 @@
color: var(--cx-text-dim);
}

/* The tab seg sits by the heading. Sharing the auto margin with the grouping
seg would slide it right whenever the PRs tab hides that seg. */
.bridge-toolbar .bridge-tabs {
margin-left: 0;
}

.seg {
display: flex;
margin-left: auto;
Expand Down
2 changes: 1 addition & 1 deletion apps/ui/src/components/Bridge.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ export const Bridge: Component = () => {
<span class="sub">
{boardAgents().length} agents · {inFlight()} in-flight issues
</span>
<div class="seg" role="toolbar" aria-label="Board view">
<div class="seg bridge-tabs" role="toolbar" aria-label="Board view">
<button
type="button"
class={{ active: tab() === "issues" }}
Expand Down
Loading