Repository navigation
[Fix] Session replies show visual-proof uploads as links - #3201
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 24, 2026 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Visual-proof uploads no longer trigger a separate parent Session event as soon as each image finishes uploading. The child task's explicit parent report remains responsible for sharing selected screenshot IDs through the existing native Slack image-block and Discord image payload paths. Other artifact types continue to notify the parent as before.
Why this change was made
The parent-report contract says visual-proof uploads are not shared automatically, but artifact upload completion still notified the parent for every artifact type. This let the parent create one link-based reply per screenshot before the child sent its consolidated report with image IDs.
Impact
Visual-proof screenshots stay private until the child report selects them, avoiding premature per-image link replies while preserving same-task/run authorization and native image delivery. The available Slack context exposes message text and file counts but not block payloads; Slack image blocks are not Slack file uploads, so
fileCountalone cannot determine whether a recap displayed images.