Repository navigation
fix(backend): port cold restart receipt validation - #328
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
1 similar comment
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Note Review skipped Codemetrics is installed on this repository, but it hasn't been added to your team yet. To enable AI code reviews for this repo, go to your dashboard and add BaseScanning to your team's repositories. |
What changed
capture_cold_restart.pyimportedload_receipt, but commit596ed9a9replaced that helper withreceipt_problem. Importingtests/test_capture_cold_restart.pytherefore raised 14 collection errors. The cold-restart script now reads the JSON receipt directly and uses the replacement validator.Why
The cold-restart runner still needs per-field errors for receipts that predate the replay fields. It keeps that existing diagnostic path while using
receipt_problemto reject receipts with the wrong runner.How it works
The primary and resume legs parse the saved receipt, reject an invalid runner, and continue through the existing fixture and replay checks. The top-level command still reports each missing replay field separately.
UI changes
N/A. This changes a backend script only.
Verification
env -u NODE_ENV OMP_NUM_THREADS=1 uv run --frozen --extra api pytest -q tests/test_capture_cold_restart.pyfailed during collection with 14ImportErrors.env -u VIRTUAL_ENV -u NODE_ENV OMP_NUM_THREADS=1 .venv/bin/python -m pytest -q tests/test_capture_cold_restart.pypassed, 14 tests, with one existing deprecation warning.Risk
The change is limited to receipt loading in the cold-restart script. Full project checks were not run.
Checklist
N/A for the last two checklist items because this PR has no visible or interactive changes.
🤖 Generated with Claude Code