Skip to content

fix(backend): port cold restart receipt validation #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamGu-NRX merged 1 commit into from
Oct 23, 2026
Merged

fix(backend): port cold restart receipt validation #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions backend/scripts/capture_cold_restart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
TERMINAL_EVENTS,
TERMINAL_STATUSES,
check_fixture,
load_receipt,
receipt_problem,
)
from server.api.app import create_app # noqa: E402
from server.common.config import Settings # noqa: E402
Expand Down Expand Up @@ -291,7 +291,10 @@ def record(step: str, **fields) -> None:

try:
client = DeviceClient(server_url)
receipt = load_receipt(receipt_path)
receipt = json.loads(receipt_path.read_text())
problem = receipt_problem(receipt)
if problem:
raise ValueError(f"{receipt_path}: {problem}")
packet_dir = _resolve_packet_dir(receipt, packet_dir)
fixture = check_fixture(packet_dir, receipt, errors)
record("fixture", packetDir=str(packet_dir), files=len((fixture or {}).get("packet", {}).get("files", [])))
Expand Down Expand Up @@ -441,7 +444,10 @@ def record(step: str, **fields) -> None:
raise RuntimeError(f"no client journal at {journal_path}: the primary leg never ran")
journal = json.loads(journal_path.read_text())
client = DeviceClient(server_url)
receipt = load_receipt(receipt_path)
receipt = json.loads(receipt_path.read_text())
problem = receipt_problem(receipt)
if problem:
raise ValueError(f"{receipt_path}: {problem}")
packet_dir = _resolve_packet_dir(receipt, packet_dir)
fixture = check_fixture(packet_dir, receipt, errors)
record("fixture", packetDir=str(packet_dir), files=len((fixture or {}).get("packet", {}).get("files", [])))
Expand Down Expand Up @@ -736,10 +742,14 @@ def run_cold_restart(
"ok": False,
}
errors = report["errorCodes"]
receipt = load_receipt(receipt_path)

# Fail before anything is sent: a pre-replay-field receipt is a caller
# mistake, and the report must name the field instead of guessing.
receipt = json.loads(receipt_path.read_text())
problem = receipt_problem(receipt)
if problem == "not_a_capture_flow_e2e_receipt":
errors.append(problem)
return _finish(report, errors, f"{receipt_path}: {problem}")

# Keep the cold-restart report's per-field diagnostics when the shared
# validator rejects a receipt without its replay block.
missing = missing_replay_fields(receipt)
if missing:
report["missingReceiptFields"] = missing
Expand Down