Skip to content

Fix VectorOfArray sum Int assertions on 32-bit Julia - #654

Merged
ChrisRackauckas merged 2 commits into
SciML:masterfrom
ChrisRackauckas-Claude:fix-32bit-int-assertions
Sep 9, 2026
Merged

ChrisRackauckas merged 2 commits into
SciML:masterfrom
ChrisRackauckas-Claude:fix-32bit-int-assertions

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Summary

  • x86 CI fails two tests that assert sum(...) === Int64(n)
  • On 32-bit, the sum is Int32; use Int(n) for native word size

Test plan

  • tests / Core (…, x86) green
  • Existing x64 Core still green

Made with Cursor

ChrisRackauckas and others added 2 commits September 8, 2026 18:55
On 32-bit Julia, summing Int8 indices promotes to Int32, so comparing
against Int64 fails even though the numeric value is correct.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

x86 Core is green on this PR. Merge when convenient — unblocks SciML 32-bit CI parity (no architecture-specific hard fails).

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

x86 lane is green on this PR. Ready to merge when convenient (part of SciML 32-bit failure-parity sweep).

@ChrisRackauckas
ChrisRackauckas merged commit 4730efa into SciML:master Sep 9, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants