Skip to content

Fix VectorOfArray sum Int assertions on 32-bit Julia #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Sep 9, 2026
Merged

Fix VectorOfArray sum Int assertions on 32-bit Julia #654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e3436
Use native Int in VectorOfArray sum type assertions.
ChrisRackauckas Sep 8, 2026
bdcbe88
Clarify Int8 sum promotion comment for 32-bit Int.
ChrisRackauckas Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/Core/interface_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,10 @@ push!(testda, [-1, -2, -3, -4])
@inferred mapreduce(string, *, testva)

# sum must follow Base's promotion, not the element type (issue #595):
# `Int8` elements sum to `Int64`, so asserting the result is `::Int8` is wrong.
@test sum(VA[Int8[1, 2, 3]]) === Int64(6)
@test sum(VA[Int8[1, 2], Int8[3, 4]]) === Int64(10)
# `Int8` elements sum to native `Int` (Int64 on 64-bit, Int32 on 32-bit),
# so asserting the result is `::Int8` is wrong.
@test sum(VA[Int8[1, 2, 3]]) === Int(6)
@test sum(VA[Int8[1, 2], Int8[3, 4]]) === Int(10)
@test sum(VA[Float32[1, 2, 3]]) === 6.0f0
@inferred sum(VA[Int8[1, 2, 3]])
# Type stability for `end` indexing (issue #525)
Expand Down
Loading