Repository navigation
refactor(provision)!: suffix the start scale pair _on_start - #14
Merged
Merged
Conversation
A semiplot_tags column holds either a live pen setting, which a running SemiPlot chart picks up at the next catalogue read, or a start value: what a pen opens with in a new window, never changed by a chart already open. Start values carry the _on_start suffix. Only enabled_on_start did; the start scale pair was scale_min/scale_max. Rename the pair to scale_min_on_start/scale_max_on_start in the CREATE TABLE, the semiplot_tags_scale_paired constraint, the semiplot column grant and the tests that spell the column set out. No installation runs a database provisioned by an earlier release, so the rename edits the CREATE TABLE alone, issues no ALTER and keeps schema_version at 1. A database provisioned by v0.4.0 is recreated, not provisioned again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A
semiplot_tagscolumn holds either a live pen setting or a start value: what a pen opens within a new SemiPlot window, never changed by a chart already open. Start values carry the
_on_startsuffix, but onlyenabled_on_startdid; the start scale pair wasscale_min/scale_max. Semiteq/SemiPlot#72 adds a third start value, so the naming is madeuniform first.
Change
scale_min/scale_maxbecomescale_min_on_start/scale_max_on_startin theCREATE TABLE, thesemiplot_tags_scale_pairedconstraint,plotEditableTagColumns(thesemiplotcolumn grant and the write probe) and the four tests that spell the column set out.
CREATE TABLEalone: noALTER,schema_versionstays1.docs/architecturesays the version rule starts with the firstinstallation.
request right after
v0.5.0.Verification
go test -count=1 ./...,go vet ./...,golangci-lint run: pass, 0 issues.git grep -nw "scale_min\|scale_max" -- ':!docs/plans'prints nothing.sitetwice on PostgreSQL 17 andbenchon 14 ran against throwaway containers duringreview; the CI
linuxjob on this pull request is the gate.