Skip to content

Remove GitHub Actions macOS jobs ported to Bitrise ci-ios - #910

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
remove-swift-test-gha
Oct 6, 2026
Merged

kieran-osgood-shopify merged 1 commit into
mainfrom
remove-swift-test-gha

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

Removes the jobs from GHA that are now running in ci-ios on bitrise
ci-ios is now a required status check and have been running stable, which means these GHA are no longer needed

I identified that swift-lint is not ported yet, so thats left behind, PR #911 upstack to investigate moving those over too, and whether they receive a useful speed improvement or not


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroidRelease in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
  • Kit's embeddedCheckoutProtocolAndroid still references an available Maven Central release
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md
  • The ECP version in embeddedCheckoutProtocolAndroid is published, and normal Android CI passes against it
Releasing a new React Native version?
  • I have bumped version in platforms/react-native/modules/@shopify/checkout-kit-react-native/package.json
  • Any updated checkoutKit.nativeSdkVersions pins are available on Maven Central/CocoaPods
  • Normal RN Android tests and the sample build pass against the published SDK, without --local or USE_LOCAL_SDK=1

Tip

See the Contributing documentation for the full release process per platform.
Changes spanning ECP, Android, and RN follow the dependency release sequence.

The Bitrise ci-ios pipeline now owns the Swift package tests, the Swift
sample build and test, the React Native iOS sample build, and the React
Native iOS tests, and its Checkout Kit iOS check is required. The
GitHub Actions copies duplicated that work on macOS runners.

Delete their workflows and drop them from ci.yml and CI Required. The
reactNativeIos filter only gated the two React Native iOS jobs, so it
goes with them.
@kieran-osgood-shopify
kieran-osgood-shopify added this pull request to stack #912 October 6, 2026 11:05
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Bundle Size Budgets

Budget Size Limits Result
— — — ➖ No configured budgets affected

Bundle and package size

Web bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.

Platform Measurement Compression Base Head Delta
- - - - - -
How sizes are measured

Measured from the PR base SHA and PR head SHA. Web bundle rows sum shipped .js, .mjs, and .cjs files under dist/, excluding source maps and declarations. The gzip bundle size sums files compressed individually with gzip -n -9. npm package sizes are gzip-compressed .tgz archives; Android AAR sizes are ZIP archives. Package sizes are not final app binary sizes.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Protocol — Coverage Report

Lines Statements Branches Functions
Coverage: 94%
93.49% (158/169) 89.16% (107/120) 90.9% (30/33)

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.97% (363/399) 87.29% (213/244) 100% (92/92)

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 96%
95.16% (374/393) 84.32% (199/236) 97.08% (100/103)

@kieran-osgood-shopify
kieran-osgood-shopify merged commit 89ea1fa into main Oct 6, 2026
73 of 78 checks passed
@kieran-osgood-shopify
kieran-osgood-shopify deleted the remove-swift-test-gha branch October 6, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants