Repository navigation
Port the remaining macOS checks to the Bitrise ci-ios pipeline - #911
Draft
kieran-osgood-shopify wants to merge 2 commits into
Draft
kieran-osgood-shopify wants to merge 2 commits into
kieran-osgood-shopify wants to merge 2 commits into
Conversation
kieran-osgood-shopify
added this pull request to stack #912
October 6, 2026 11:05
Bundle Size Budgets
Bundle and package sizeWeb bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.
React Native package files (uncompressed)These are uncompressed file sizes; they do not sum to the compressed package size above.
How sizes are measuredMeasured from the PR base SHA and PR head SHA. Web bundle rows sum shipped |
16 tasks
kieran-osgood-shopify
force-pushed
the
bitrise-ci-ios-port-lint-and-api-checks
branch
from
October 6, 2026 12:31
d130401 to
ae98229
Compare
Four macOS jobs still ran on GitHub Actions after the ci-ios port: Swift SwiftFormat & SwiftLint, the CocoaPods podspec lint, the Swift public API baseline check, and React Native SwiftFormat & SwiftLint. Add them to ci-ios as swift-lint, swift-podspec-lint, swift-api-check, and react-native-lint-ios, with the same commands and the same changed-file selection GitHub Actions used, and delete the GitHub copies. The Linux SwiftLint annotation jobs stay on GitHub Actions. setup-mint has no remaining user, so it goes too. lint_swift now requires Mint-resolved tools on any CI, not only GitHub Actions.
kieran-osgood-shopify
force-pushed
the
bitrise-ci-ios-port-lint-and-api-checks
branch
from
October 7, 2026 08:34
ae98229 to
e36b306
Compare
The ci-ios-swift-podspec-lint gem cache never hit. Bitrise's Ruby platform is missing from platforms/swift/Gemfile.lock, so bundle install rewrites the lockfile, and save-cache keyed on it saved under a different key than restore-cache looked up. Key on a snapshot of the committed lockfile instead. Also pin the real config's selection for the React Native bridge lint, correct test comments left over from the four-job port, point the linter-bump PR at close-and-reopen now that swift-lint.yml no longer runs the pinned linters, and name the required ci/bitrise/ci-ios/pr check in CONTRIBUTING.md.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
After #910, four macOS checks still ran on GitHub Actions.
This PR moves them into the Bitrise
ci-iospipeline, so no macos PR check runs on a GitHub macOS runner any more.ci-iosjobSwift / SwiftFormat & SwiftLintswift-lintplatforms/swift/Scripts/lint check --verbose --skip-podSwift / CocoaPodsswift-podspec-lintpod lib lint ShopifyCheckoutKit.podspec --allow-warningsBreaking Changes / Swiftswift-api-checkplatforms/swift/Scripts/api checkReact Native / SwiftFormat & SwiftLintreact-native-lint-iosplatforms/react-native/scripts/lint_swift checkPackage.swift-only change, because it lints Swift source only.SwiftLintannotation jobs inswift-lint.ymlandrn-lint.ymlstay on GitHub Actions..github/actions/setup-mintaction has no remaining users, so this PR deletes it.lint_swiftnow requires Mint-resolved tools whenCI=true. Before, it checkedGITHUB_ACTIONS, which Bitrise does not set.Timings, 5 runs each
GitHub "before" times come from the last 5 successful
CIruns. Bitrise "after" times come from 5 manualci-iosruns of this branch with every job selected: #2319, #2324, #2337, #2340, #2343. Run 1 had a cold cache for the new Swift gems.Swift / SwiftFormat & SwiftLint→ci-ios-swift-lintSwift / CocoaPods→ci-ios-swift-podspec-lintBreaking Changes / Swift→ci-ios-swift-api-checkReact Native / SwiftFormat & SwiftLint→ci-ios-react-native-lint-iosci-iospipeline, all jobs selectedBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidReleaseinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedembeddedCheckoutProtocolAndroidstill references an available Maven Central releaseReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdembeddedCheckoutProtocolAndroidis published, and normal Android CI passes against itReleasing a new React Native version?
versioninplatforms/react-native/modules/@shopify/checkout-kit-react-native/package.jsoncheckoutKit.nativeSdkVersionspins are available on Maven Central/CocoaPods--localorUSE_LOCAL_SDK=1Tip
See the Contributing documentation for the full release process per platform.
Changes spanning ECP, Android, and RN follow the dependency release sequence.