Repository navigation
Reduce the web checkout overlay bundle size - #916
Merged
Merged
Conversation
This was referenced Oct 6, 2026
Bundle Size Budgets
Bundle and package sizeWeb bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.
Web package files (uncompressed)These are uncompressed file sizes; they do not sum to the compressed package size above.
How sizes are measuredMeasured from the PR base SHA and PR head SHA. Web bundle rows sum shipped |
markmur
force-pushed
the
mm-web-overlay-bundle
branch
from
October 6, 2026 11:33
bd67c87 to
dedd28e
Compare
markmur
changed the base branch from
ks-web-blocked-popup-event
to
ks-web-blocked-popup-session
October 6, 2026 11:33
kyle-schellen
approved these changes
Oct 6, 2026
kyle-schellen
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this Mark!
kyle-schellen
added a commit
that referenced
this pull request
Oct 6, 2026
* Fix blocked popup session state * Warn and document when the checkout window is blocked * Show a retry overlay when the checkout window is blocked * Treat any open() while the blocked overlay shows as a retry * Use the renamed close event in blocked-overlay tests and README * Keep the blocked-overlay close event out of the custom elements manifest * Document the blocked-window telemetry mapping * Keep the blocked message while the overlay fades out * Keep a session opened from a close listener open * Test the blocked overlay's close and retry paths * Keep the blocked session when the overlay is hidden * Test the dialog's late close event after a retry * Document close after a blocked window * Share web checkout overlay markup and lifecycle handling (#916) * Clarify that the browser blocked the checkout window from opening --------- Co-authored-by: Mark Murray <2034704+markmur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The normal and blocked checkout overlays duplicate fallback markup and dialog listeners, pushing the Web bundle above its soft size budget. Generate both variants from one template and share dialog setup and cleanup while preserving independently replaceable slots and retry behavior.
The shipped JavaScript shrinks from 35,918 to 34,729 bytes (35.08 → 33.92 KiB), saving 1,189 bytes and bringing the bundle below the 35 KiB soft limit. Gzip size decreases from 10,761 to 10,737 bytes.
Stack