Skip to content

Remind users to enable push notifications every 30 days - #2669

Merged
MusabShakeel576 merged 1 commit into
masterfrom
codex/notification-reminder-30-days
Oct 8, 2026
Merged

MusabShakeel576 merged 1 commit into
masterfrom
codex/notification-reminder-30-days

Conversation

@creatix

@creatix creatix commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Dismissed notification onboarding previously never returned. This change offers the notification sheet on Home every 30 days while notifications are disabled. Existing installs without a saved prompt timestamp are eligible on their first Home visit; dismissal and presentation are persisted to prevent repeated prompts after a restart.

The reminder waits for Home to settle and pauses while What's New, card details, or a deposit flow is open. Users who already granted permission are skipped. After an OS denial, the sheet opens notification Settings instead of issuing another permission request.

Validation:

  • 57 focused tests passed, covering timing, legacy persisted state, permission handling, navigation, and foreground races.
  • Lint and iOS/Android OTA bundle exports passed.
  • Native fingerprints are unchanged on both platforms. This change requires no new native binary and leaves the existing production OTA workflow intact.
  • The full project typecheck reports 9 unrelated errors; none are in the changed files.

This PR targets master. No OTA has been published.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@vercel

vercel Bot commented Oct 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
solid-app Ignored Ignored Oct 8, 2026 12:24pm UTC
solid-app-staging Ignored Ignored Oct 8, 2026 12:24pm UTC

Request Review

@claude

claude Bot commented Oct 8, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@MusabShakeel576
MusabShakeel576 merged commit b00cb3f into master Oct 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants