Repository navigation
fix(card): stop reading the retired Bridge customer in the card flow - #2676
Open
MayankMittal1 wants to merge 1 commit into
Open
MayankMittal1 wants to merge 1 commit into
MayankMittal1 wants to merge 1 commit into
Conversation
Bridge cards are retired, but every card screen still called /bridge-customer/get-customer-from-bridge (now failing with a 400) and, when a Bridge KYC link id was saved on the device, polled /cards/kyc/kyc-link-from-bridge every 5s. The card flow now reads /cards/status alone. - Card steps no longer fall back to the Bridge "cards" endorsement for an applicant with no card customer. An approved endorsement offered "Activate card", which the backend refuses; they now start verification like everyone else. - The card KYC status is no longer overridden by a Bridge KYC link left over from bank-transfer KYC. - Add funds / Withdraw no longer hide on a paused or offboarded Bridge account; that hold is Bridge's, not the card issuer's. The bank-transfer flow still reads the Bridge customer: Bridge's fiat rails are live. Playwright scenarios built on Bridge endorsements are replaced with ones driven by /cards/status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bridge cards are retired, but every card screen still called
GET /bridge-customer/get-customer-from-bridge. That endpoint now returns 400. If a Bridge KYC link id was saved on the device, the card screens also polled/cards/kyc/kyc-link-from-bridgeevery 5s. After this PR the card flow reads/cards/statusonly.Behaviour
cardsendorsement: approved offered "Activate card", which the backend refuses/cards/statusonlyScope
useCustomer,PaymentMethodList,/bank-transfer/*). Bridge's fiat rails are still live; seekyc.service.tsin solid-backend.useCustomeris now documented as bank-transfer-only.useKycLinkFromBridge,useKycLink,useCreateKycLink,getKycLinkFromBridge,getKycLink,KycLinkFromBridgeResponse,isCustomerFundsRestricted.card-creation.spec.tsscenarios built on Bridge endorsements are replaced by under-review, rejected and approved scenarios driven by/cards/status. The old ones were already stale; they looked for an "Order card" button that no longer exists.Before merging
Please confirm there are no live Bridge cardholders. The paused/offboarded row is the only change that removes a restriction, and it only matters for someone Bridge has paused who also holds a live card.
Verification
tsc --noEmit: same 10 errors as master, all in untouched filesbuildCardSteps.test.ts: 23/23cardReviewState.test.ts: 14/14cardFundsAccess.test.ts: 6/6SpendModeModals.test.tsx: 10/10🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.