Repository navigation
fix(ai-ollama): keep parallel same-name tool calls apart when ids are missing #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pcbeingused333
wants to merge
1
commit into
TanStack:main
Choose a base branch
from
pcbeingused333:fix/ollama-parallel-tool-ids
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/ai-ollama': patch | ||
| --- | ||
|
|
||
| Keep parallel calls to the same tool apart when Ollama sends no tool-call id. The fallback id was `<name>_<Date.now()>`, so two calls to one tool in the same millisecond shared an id and the second call was dropped. The fallback id now also carries the call's index. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: TanStack/ai
Length of output: 11600
Script executed:
Repository: TanStack/ai
Length of output: 44247
Script executed:
Repository: TanStack/ai
Length of output: 43500
Script executed:
Repository: TanStack/ai
Length of output: 40968
Web query:
Ollama v0.12.6 api/types.go ToolCallFunction Index json index tool callsResult:
Script executed:
Repository: TanStack/ai
Length of output: 13239
Use the local array index for ID-less Ollama calls.
Ollama’s
ToolCalltype has no ID field, andToolCallFunction.Indexis a plain integer that can be0. If parallel calls share index0, the fallback IDs collide in the same millisecond andtoolCallsEmittedsuppresses the second start.Different timestamps do not fix the full issue.
ToolCallManagerkeys calls by emittedindex, so repeated index0overwrites the earlier call. Use eachtool_callsarray position for ID-less calls in both the fallback ID and emitted index. Preserve provider-supplied IDs and indexes.Suggested fix