Skip to content

Audio-end clipping uses note pitch instead of duration - #244

Merged
dgruss merged 1 commit into
mainfrom
fix/audio-end-duration
Oct 28, 2026
Merged

dgruss merged 1 commit into
mainfrom
fix/audio-end-duration

Conversation

@dgruss

@dgruss dgruss commented Oct 28, 2026 •

Copy link
Copy Markdown

Notes fitting inside the audio could be excluded based on pitch: with 12 seconds of audio, #BPM:60 and : 0 4 60, the one-second note was treated as ending at 15 seconds.

Use absolute note start plus duration, including relative-note offsets and GAP, for audio-boundary checks. Conversion to freestyle, the diagnostic and exclusion from scoring now share that result. The existing exclusive audio-end boundary is unchanged.

The native parser regression reproduces the failure before the fix and passes afterward. It covers different pitches, notes before/at/after the audio boundary, START, GAP, relative offsets, disabled clipping, unknown audio length and positive freestyle weight. The #243 completion regression also passes. Actual game playback with synthetic PCM through the pitch detector now saves 10000 points for both the 12-second and 30-second audio fixtures; previously only the longer audio worked. Temporary test hooks were removed.

No independent human review is available during the solo-maintainer phase.

dgruss commented Oct 28, 2026

Copy link
Copy Markdown
Author

Reproduced independently on main 21bd3d5d and #243 at 528d33e5, using the actual pitch detector and isolated score databases.

Audio length, identical notes Main #243
12 seconds Note converted to freestyle, ScoreExcluded=True, 0 points Same
30 seconds Normal note, ScoreExcluded=False, 10000 points saved Same

This is a pre-existing clipping bug, not a regression from #243. The source uses Param3 (pitch) in the audio-end check where the note duration belongs. No clipping fix has been included in #243.

@dgruss
dgruss merged commit 612520e into main Oct 28, 2026
7 checks passed
@dgruss
dgruss deleted the fix/audio-end-duration branch October 28, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant