Repository navigation
Audio-end clipping uses note pitch instead of duration - #244
Merged
Merged
Conversation
Author
|
Reproduced independently on main
This is a pre-existing clipping bug, not a regression from #243. The source uses Param3 (pitch) in the audio-end check where the note duration belongs. No clipping fix has been included in #243. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes fitting inside the audio could be excluded based on pitch: with 12 seconds of audio,
#BPM:60and: 0 4 60, the one-second note was treated as ending at 15 seconds.Use absolute note start plus duration, including relative-note offsets and GAP, for audio-boundary checks. Conversion to freestyle, the diagnostic and exclusion from scoring now share that result. The existing exclusive audio-end boundary is unchanged.
The native parser regression reproduces the failure before the fix and passes afterward. It covers different pitches, notes before/at/after the audio boundary, START, GAP, relative offsets, disabled clipping, unknown audio length and positive freestyle weight. The #243 completion regression also passes. Actual game playback with synthetic PCM through the pitch detector now saves 10000 points for both the 12-second and 30-second audio fixtures; previously only the longer audio worked. Temporary test hooks were removed.
No independent human review is available during the solo-maintainer phase.