fix(specs): show correct host for MX endpoints in merged API reference#83
Open
walletconnect-agent[bot] wants to merge 1 commit into
Open
fix(specs): show correct host for MX endpoints in merged API reference#83walletconnect-agent[bot] wants to merge 1 commit into
walletconnect-agent[bot] wants to merge 1 commit into
Conversation
generate-specs.mjs merged Core+MX specs but only set a document-level Core server, so MX endpoints rendered api.pay.walletconnect.com instead of api.merchant.pay.walletconnect.com. Tag each operation with its source service's server URL.
Contributor
Author
|
Closing/abandoning this — confirmed in thread that MX endpoints are already routed under The real remaining issue is snapshot staleness (phantom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/generate-specs.mjsmerges the Core and MX OpenAPI specs into one document but sets only a document-level server pointing at Core (api.pay.walletconnect.com). MX-sourced endpoints inherit it, so the docs page + playground show the wrong host for merchant-API endpoints.Fix
When merging, stamp each operation with its source service's server (
servers: [{ url }]) — Core ops get the Core host, MX ops getapi.merchant.pay.walletconnect.com. Mintlify respects per-operationservers. Only real HTTP-method keys are stamped, and any pre-existing operationserversis preserved.Follow-up (not in this PR)
The committed snapshot (
api/2026-02-18.json+api-reference/MDX) is regenerated by fetching the live service specs, which only runs via the manual Update OpenAPI Specs workflow (workflow_dispatch). A maintainer needs to re-run it to (a) apply this per-service-server fix to the output and (b) refresh the stale snapshot (e.g. add Core's/v1/payments/{id}/transition, drop the phantomGET /v1/payments). Consider adding a schedule/trigger so it stops drifting.Thread: https://reown-inc.slack.com/archives/C0A1N1Q7XS8/p1783931638893429