Skip to content

fix(specs): show correct host for MX endpoints in merged API reference #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
walletconnect-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(specs): show correct host for MX endpoints in merged API reference #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions scripts/generate-specs.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,32 @@ function mergeSpecs(specs, version) {

const seenTags = new Set();

for (const spec of specs) {
const HTTP_METHODS = new Set([
"get",
"put",
"post",
"delete",
"options",
"head",
"patch",
"trace",
]);

for (let i = 0; i < specs.length; i++) {
const spec = specs[i];
const serviceUrl = SERVICES[i]?.baseUrl;
for (const [path, methods] of Object.entries(spec.paths || {})) {
merged.paths[path] = { ...(merged.paths[path] || {}), ...methods };
// Stamp each operation with the server of the service it came from, so
// merged endpoints render their real host (Core vs MX) instead of
// inheriting the document-level Core server.
const stamped = {};
for (const [key, value] of Object.entries(methods)) {
stamped[key] =
serviceUrl && HTTP_METHODS.has(key.toLowerCase()) && !value.servers
? { ...value, servers: [{ url: serviceUrl }] }
: value;
}
merged.paths[path] = { ...(merged.paths[path] || {}), ...stamped };
for (const op of Object.values(methods)) {
for (const tagName of op.tags || []) {
if (!seenTags.has(tagName)) {
Expand Down