Conversation
…ll checks ABISerializableObject declares toABI optional, so narrowing to it left the call possibly undefined under the strict-null typecheck and failed test:ci on master (and the v1.0.93 tag-release). Narrow to a type whose toABI is present. Change-Id: I6b4a61bcdf946c5b0ab2066fb65332cbd6d0c55c
huangminghuang
previously approved these changes
Sep 26, 2026
huangminghuang
left a comment
huangminghuang
left a comment
Contributor
There was a problem hiding this comment.
Verified the strict-null failure on master in a registry-only Node 24 checkout. The predicate now accurately reflects the runtime toABI function check without changing runtime behavior; pnpm run test:ci passes (90 suites, 981 tests).
huangminghuang
dismissed
their stale review
September 26, 2026 16:58
Approval removed at the requester’s direction.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strict-null typecheck fails on master (
pnpm run test:ci→typecheck:strict-null:sdk-core):The type guard added in #90 narrowed to
ABISerializableObject, whosetoABIis optional, so the call stayed possibly-undefined. It now narrows to a type whosetoABIis present. There is no behaviour change.This failed the v1.0.93
tag-releaserun (36179924054), so sdk-core 1.0.93 was never published. After this merges,tag-releaseneeds a manual re-dispatch; master already carries the 1.0.93 version bump.Verified with the real gate:
pnpm run test:cipasses (strict-null typecheck included), 90 suites / 981 tests, and lint is clean.