Skip to content

fix(sdk-core): narrow the slug_name self-encoding guard for strict null checks #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heifner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(sdk-core): narrow the slug_name self-encoding guard for strict null checks #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/sdk-core/src/serializer/Builtins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,9 @@ const SlugNameType = {
value === SLUG_NAME_ZERO
? SLUG_NAME_ZERO
: SlugName.toString(slugValue(value, SlugNameType.abiName)),
toABI: (
value: SlugNameValue | ABISerializableObject,
encoder: ABIEncoder
) => {
toABI: (value: SlugNameValue | SelfEncodingValue, encoder: ABIEncoder) => {
match(value)
.when(isSerializable, serializable => serializable.toABI(encoder))
.when(isSelfEncoding, selfEncoding => selfEncoding.toABI(encoder))
.with(SLUG_NAME_ZERO, () => UInt64.from(0).toABI(encoder))
.otherwise(carrier =>
UInt64.from(
Expand All @@ -96,8 +93,13 @@ const SlugNameType = {
}
}

/** True for an already-typed ABI value, e.g. a `ChainsSlugName` passed to the generic encoder. */
function isSerializable(value: unknown): value is ABISerializableObject {
/** An already-typed ABI value that encodes itself, e.g. a `ChainsSlugName`. */
interface SelfEncodingValue {
toABI(encoder: ABIEncoder): void
}

/** True for a value whose `toABI` is present — `ABISerializableObject` declares it optional. */
function isSelfEncoding(value: unknown): value is SelfEncodingValue {
return (
typeof value === "object" &&
value !== null &&
Expand Down
Loading