Skip to content

Update terrains.json - #2

Closed
Xolgrim wants to merge 1 commit into
developfrom
add-land-flagg-to-firewall
Closed

Update terrains.json#2
Xolgrim wants to merge 1 commit into
developfrom
add-land-flagg-to-firewall

Conversation

@Xolgrim

@Xolgrim Xolgrim commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Feuerwand zu Landregion gemacht, damit Schiffe in der Nähe nicht mehr abtreiben können.

Feuerwand zu Landregion gemacht, damit Schiffe in der Nähe nicht mehr abtreiben können.
@Xolgrim Xolgrim closed this Aug 20, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0d1f612b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread conf/e2/terrains.json
},
"firewall": {
"flags": [ "forbidden" ]
"flags": [ "forbidden", "land" ]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Count firewalls as shore in storm drift logic

When a ship is adjacent to a firewall terrain, this flag change still does not prevent storm drift: the drift check skips every FORBIDDEN_REGION neighbor before testing SEA_REGION (src/move.c:2006-2009), so a forbidden+land firewall is ignored rather than treated like coastline. In an otherwise all-sea neighborhood, storm remains true and rnext can still be selected, so ships can continue to drift near firewalls unless the storm neighbor test is changed to make forbidden land break the open-sea condition.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant