Skip to content

Update terrains.json #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Xolgrim wants to merge 1 commit into from
+1 −1
Closed

Update terrains.json #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conf/e2/terrains.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@
}
},
"firewall": {
"flags": [ "forbidden" ]
"flags": [ "forbidden", "land" ]

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Count firewalls as shore in storm drift logic

When a ship is adjacent to a firewall terrain, this flag change still does not prevent storm drift: the drift check skips every FORBIDDEN_REGION neighbor before testing SEA_REGION (src/move.c:2006-2009), so a forbidden+land firewall is ignored rather than treated like coastline. In an otherwise all-sea neighborhood, storm remains true and rnext can still be selected, so ships can continue to drift near firewalls unless the storm neighbor test is changed to make forbidden land break the open-sea condition.

Useful? React with 👍 / 👎.

},
"fog": {
"flags": [ "walk", "fly" ]
Expand Down