[bokelley]

Summary

Adopts the signed AdCP 3.3.0-beta.3 release and serves its reporting-subscription surface: T1(a) of the reporting-subscriptions DX plan (#3504).

Stacks on #3557 (bokelley/reporting-subscription-dx-docs, the top of the #3504 stack) plus a clean merge of origin/main. It targets main so CI runs; the diff against main includes the whole stack.

Review these commits:

• 5e35609e feat: adopt signed AdCP 3.3.0-beta.3 and serve the reporting-subscription surface
• 4e881b08 fix: carry the task status on terminal webhook results and update fixtures for beta.3
• (9924a4b4 merges origin/main; no conflicts)

The engine rules beta.3 adds (#8617, #8618, #8619, #8620, #8622) land in the follow-up PR on bokelley/reporting-subscription-beta3-engine.

Release

• v3.3.0-beta.3, spec commit a6106149a2b5c929eec0caa0042adbae4ccf3a9c
• Bundle SHA-256 ba61919ca0c9d67874604fbbca8945c133eaceed65da1ac962f78d94d7879f00, cosign-verified (ADCP_REQUIRE_SIGNATURE=1 ADCP_GITHUB_FALLBACK=0)
• The pin is 3.3.0-beta.3, and the wire version is 3.3-beta.3.

Warning

Beta-channel break. The SDK advertises and negotiates only 3.3-beta.3. A beta.2 peer (SDK 17.0.0-beta.10) falls back to a shared stable release (3.2.7, 3.1.31 or 3.0.25). An explicit adcpVersion: '3.3.0-beta.2' pin now throws.

What changes

Signed sync and generated files (following #3541)

• ADCP_VERSION, version.ts, package.json (adcp_version and the packaged compliance cache).
• Regenerated: types, Zod, enums, manifest, entity hydration, wire-spec fields, llms.txt, TYPE-SUMMARY.md and the worksheet.
• Canonical storyboard provenance moves to the beta.3 tag and commit. The principal.yaml and reporting-core.yaml bytes are unchanged.
• The A2A vectors are byte-identical; only the README provenance changed.
• Commercial-terms semantics: beta.3 carries the beta.2 contracts, which I checked against the bundle. The beta.3 entry reuses the beta.2 one.

Reporting subscriptions

• wire.ts and every TODO(3.3.0-beta.2) are deleted. The generated ReportingDeliveryOffering, ReportingSubscriptionCoverage and ReportingSubscriptionState carry all of these fields:

  • standard_dimensions
  • inactive_intervals
  • prior_versions[].configuration
  • previous_timezone
  • per-offering offering_id
  • status: inactive with deactivated_at

  ReportingSubscriptionOfferingV1 is now an alias of ReportingDeliveryOffering. The wire.ts file-budget line is dropped.

• authorization.regranted_at joins ACCOUNT_AUTHORIZATION_WIRE_KEYS, which unblocks the spec repo's "Generate TypeScript SDK" check. toWireAccount and windDownGrant keep it.

• Readback totals (adcp#8619). Without these, beta.3 responses fail validation.

  • prior_versions_count, accounts_with_exceptions_count and accounts_unauthorized_count are served.
  • prior_versions is capped at 16 inline.
  • Each total is gated on the served bundle, like the other settled fields.

• Release gate. It is kept for callers served older releases. It now resolves local #/definitions refs, because beta.3 names its item shapes. A response with no served release uses the pinned release, which matches Python's serves_subscriptions and plan §3.1. So inactive coverage is now served to beta.3 callers and to unpinned direct calls.

Canonical vectors

• Re-pinned to a6106149 (tag v3.3.0-beta.3; main is identical for this directory) with npm run sync:reporting-subscription-vectors.
• vectors.json sha256 is 56cc381b…, and there are 120 cases.
• 111 cases pass. The 9 the engine doesn't satisfy yet are named expected failures in EXPECTED_FAILURES. Each still runs and must fail, so a fixed case fails the suite until its entry is removed. Each entry names its spec PR (#8617 ×2, #8618 ×3, #8619 ×1, #8622 ×3). The engine PR removes them all.

Beta.3 contracts outside reporting (#8547 composes the protocol envelope on every response)

• Codegen: proposal submitted arms. materializeProposalResponseBranches now folds the allOf members of a referenced arm. In beta.3, compact-task-submitted.json composes task-submitted.json, so the submitted arms of request_proposals, refine_proposals and decline_proposals keep status: 'submitted' and the required task_id. Before this fix, a completed refine response with no products passed Zod.

• Codegen: Zod constraints. postProcessCanonicalPrimitiveConstraints follows core $refs and envelope-in-envelope composition. Generated responses keep their constraints on adcp_version, adcp_major_version, top-level task_id and message. Before this fix, 82 response schemas had dropped the adcp_version regex.

• Server: terminal webhook result. On 3.1+ it now carries the task status, as a synchronous response does. A lifecycle value in status moves to media_buy_status. A 3.2 list_products/decline_proposals result or a 3.0 result is unchanged.

• Notifications. creative.staged_update_changed joins ACCOUNT_NOTIFICATION_TYPES.

• Test fixtures. They now follow the beta.3 contracts:

  • status on every 3.3 response
  • request_account money terms (#8620)
  • confirmed_at/revision on a completed create
  • the canonical-format product seeded through comply_test_controller
  • validation-only storyboard steps

  Version pins read ADCP_VERSION where possible.

Checks

• Signed sync of 3.3.0-beta.3.
• typecheck, build:lib, lint:boundaries, ci:codegen-strict, check:skill-sync, ci:doc-links and check:canonical-storyboard-fixtures all pass.
• check:publish-protocol-artifacts, typecheck:examples, typecheck:skill-examples, check:adopter-types(-narrow), test:zod-openapi-portability and test:schemas-browser also pass, as does Prettier on the changed files.
• check:package-size: 26,825,751 bytes packed (25.6 MiB), 140.6 MiB unpacked, 8,528 files. The packed budget goes to 26,870,000 and the file count rises by 21 (eleven new source schemas plus storyboards), with comments.
• test:node:fast: 24,026 tests locally, all passing on this head. test:node:slow: passes. @adcp/reporting-storage: 177 passed and 1 skipped. Postgres-only cases run in CI.

Spec ambiguities and deviations

• Absent served release. TS used to serve none of the settled fields when no release was negotiated. It now uses the pin, as Python and plan §3.1 do.
• decline_proposals without status at 3.3. The buyer coordinator and the oracle treat it as the seller's defect and don't fill it in, as the envelope shim documents. They don't copy request_proposals' lenient normalization.

🤖 Generated with Claude Code

[aao-secretariat]

Ladon verdict: Approve

Approve — beta.3 delta is clean, no blocking findings.

Reviewed the beta.3-specific delta (commits 5e35609, 4e881b0 over the merged #3504 stack); generated files and the already-reviewed stack excluded.

What was checked:

• commercial-terms: clean extract-and-reuse of beta.2 semantics for beta.3.
• Codegen fixes (foldComposedOverlay, $ref-following primitive()) recover composed-envelope status/task_id/adcp_version constraints, gated by ci:codegen-strict.
• Terminal-webhook status change (webhookResultForRelease) is conservative — no-ops on undefined/pre-3.1/envelope-omitting releases; media_buy_status move is tested in server-decisioning-from-platform.test.js.
• Release-gate default flip (undefined served → pinned release, not NONE) is a documented deviation aligned with the Python SDK (DR-0008 canon).
• Readback counts (adcp#8619) set at build and projected per release; canonical-vector EXPECTED_FAILURES discipline (9 named must-fail cases, crashes still surface) is correct.
• Changeset present, minor, with a prominent beta-break note consistent with #3541.

High-risk note: high_risk is true only because bin/adcp.js was modified. Per the change-kind rules a (modified) high-risk file with no medium-or-higher findings is presumed safe; it does not escalate on the flag alone.

Low (non-blocking) follow-up: prior_versions capped at 16 unconditionally while prior_versions_count is stripped for releases lacking it — a silent truncation for an older external schema root, but unreachable via negotiation since beta.1/beta.2 left COMPATIBLE_ADCP_VERSIONS.

No gated paths, no no-auto-approve team match, no critical/high/medium findings. Falls through to row 9.

[bokelley]

Thanks. On the low note (prior_versions capped at 16 while prior_versions_count is stripped for a release without it): agreed that it only affects an older external schema root, since beta.1 and beta.2 left COMPATIBLE_ADCP_VERSIONS. The engine follow-up (bokelley/reporting-subscription-beta3-engine) adds get_principal reporting_subscription_page, which pages the full prior_versions list from history at the pinned release. I'm leaving the older-root case as is: those roots have no paging and no count field to signal truncation.

🤖 Generated with Claude Code

The merge-base changed after approval.

[aao-secretariat]

Re-approval: no reviewable delta since the prior approval; re-submitting after stale-review dismissal.