Repository navigation
Conversation
Resolve integration against current upstream while retaining the instruction semantics fix and existing source comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intel defines ZF as unaffected by BT, BTS, BTR, and BTC. The 32-bit x86 frontend currently replaces the flag state with CF alone in both register-index and immediate-index paths, incorrectly clearing a previously set ZF.
Materialize the prior flags with
mk_x86g_calculate_eflags_all(), replace CF with the selected bit, and retain ZF. Both register and memory destinations use these paths.Current master already fixes the amd64 paths, so this updated PR changes only
priv/guest_x86_toIR.c.Reproducer
Before the fix this prints 0; the expected ZF is 1.
Validation
All 64 tested 32-bit x86 cases passed across the four BT-family instructions, register/immediate indices, register/memory destinations, and prior lazy ZF values. Destination values, CF, and ZF matched the reference.
Reference: Intel SDM, Volume 2, BT/BTC/BTR/BTS, Flags Affected.