Repository navigation
GEODE-10687: Upgrade ASM to 9.11 - #8140
Conversation
utafrali
left a comment
There was a problem hiding this comment.
Clean, minimal version bump from ASM 9.10.1 to 9.11 that follows the established transitive-pin pattern used for bouncycastle and hibernate-validator. All three classpath fixture files are updated consistently, and the PR description license-compatibility checkbox (ASM is BSD-3-Clause, an ASF Category A license) can safely be ticked.
| api(group: 'org.bouncycastle', name: 'bcprov-jdk18on', version: get('bouncycastle.version')) | ||
| // GEODE-10681: Pin hibernate-validator to a fixed version | ||
| api(group: 'org.hibernate.validator', name: 'hibernate-validator', version: get('hibernate-validator.version')) | ||
| // GEODE-10687: Pin ASM (transitive via Jetty) to a fixed version |
There was a problem hiding this comment.
Only asm, asm-commons, and asm-tree are pinned here, which matches what appears in the classpath fixture files. If Jetty or another transitive ever pulls in asm-analysis or asm-util, they would not be covered by this pin. Worth noting in the JIRA ticket so the next person doing an ASM bump knows to check those modules too.
There was a problem hiding this comment.
Thanks for the quick and thorough review, @utafrali! I really appreciate you checking that the pin follows the same pattern as bouncycastle and hibernate-validator, and confirming that ASM's BSD-3-Clause license is ASF Category A. I've ticked that checkbox.
Good catch on asm-analysis and asm-util. Today only asm, asm-commons, and asm-tree reach the classpath through Jetty, so those are the ones pinned. You're right that a future Jetty upgrade could quietly bring in the others. I'll add a note to GEODE-10687 so whoever does the next ASM bump checks those modules too.
Upgrade ASM to 9.11
For all changes, please confirm:
develop)?gradlew buildrun cleanly?