Skip to content

GEODE-10687: Upgrade ASM to 9.11 - #8140

Merged
JinwooHwang merged 1 commit into
apache:support/2.0from
JinwooHwang:feature/GEODE-10687-2.0
Oct 28, 2026
Merged

JinwooHwang merged 1 commit into
apache:support/2.0from
JinwooHwang:feature/GEODE-10687-2.0

Conversation

@JinwooHwang

@JinwooHwang JinwooHwang commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Upgrade ASM to 9.11

For all changes, please confirm:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
  • Has your PR been rebased against the latest commit within the target branch (typically develop)?
  • Is your initial contribution a single, squashed commit?
  • Does gradlew build run cleanly?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@utafrali utafrali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, minimal version bump from ASM 9.10.1 to 9.11 that follows the established transitive-pin pattern used for bouncycastle and hibernate-validator. All three classpath fixture files are updated consistently, and the PR description license-compatibility checkbox (ASM is BSD-3-Clause, an ASF Category A license) can safely be ticked.

api(group: 'org.bouncycastle', name: 'bcprov-jdk18on', version: get('bouncycastle.version'))
// GEODE-10681: Pin hibernate-validator to a fixed version
api(group: 'org.hibernate.validator', name: 'hibernate-validator', version: get('hibernate-validator.version'))
// GEODE-10687: Pin ASM (transitive via Jetty) to a fixed version

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only asm, asm-commons, and asm-tree are pinned here, which matches what appears in the classpath fixture files. If Jetty or another transitive ever pulls in asm-analysis or asm-util, they would not be covered by this pin. Worth noting in the JIRA ticket so the next person doing an ASM bump knows to check those modules too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick and thorough review, @utafrali! I really appreciate you checking that the pin follows the same pattern as bouncycastle and hibernate-validator, and confirming that ASM's BSD-3-Clause license is ASF Category A. I've ticked that checkbox.

Good catch on asm-analysis and asm-util. Today only asm, asm-commons, and asm-tree reach the classpath through Jetty, so those are the ones pinned. You're right that a future Jetty upgrade could quietly bring in the others. I'll add a note to GEODE-10687 so whoever does the next ASM bump checks those modules too.

@JinwooHwang
JinwooHwang merged commit 06b981b into apache:support/2.0 Oct 28, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants