Skip to content

GEODE-10687: Upgrade ASM to 9.11 #8140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JinwooHwang merged 1 commit into from
Oct 28, 2026
+15 −9
Merged

GEODE-10687: Upgrade ASM to 9.11 #8140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...y-management/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ class DependencyConstraints {
deps.put("bouncycastle.version", "1.86")
// GEODE-10681: Pin hibernate-validator to a fixed version
deps.put("hibernate-validator.version", "8.0.6.Final")
// GEODE-10687: Pin ASM (transitive via Jetty) to a fixed version
deps.put("asm.version", "9.11")
deps.put("slf4j-api.version", "2.0.18")
deps.put("jakarta.transaction-api.version", "2.0.1")
deps.put("jboss-modules.version", "1.11.0.Final")
Expand Down Expand Up @@ -201,6 +203,10 @@ class DependencyConstraints {
api(group: 'org.bouncycastle', name: 'bcprov-jdk18on', version: get('bouncycastle.version'))
// GEODE-10681: Pin hibernate-validator to a fixed version
api(group: 'org.hibernate.validator', name: 'hibernate-validator', version: get('hibernate-validator.version'))
// GEODE-10687: Pin ASM (transitive via Jetty) to a fixed version

@utafrali utafrali Oct 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only asm, asm-commons, and asm-tree are pinned here, which matches what appears in the classpath fixture files. If Jetty or another transitive ever pulls in asm-analysis or asm-util, they would not be covered by this pin. Worth noting in the JIRA ticket so the next person doing an ASM bump knows to check those modules too.

@JinwooHwang JinwooHwang Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick and thorough review, @utafrali! I really appreciate you checking that the pin follows the same pattern as bouncycastle and hibernate-validator, and confirming that ASM's BSD-3-Clause license is ASF Category A. I've ticked that checkbox.

Good catch on asm-analysis and asm-util. Today only asm, asm-commons, and asm-tree reach the classpath through Jetty, so those are the ones pinned. You're right that a future Jetty upgrade could quietly bring in the others. I'll add a note to GEODE-10687 so whoever does the next ASM bump checks those modules too.

api(group: 'org.ow2.asm', name: 'asm', version: get('asm.version'))
api(group: 'org.ow2.asm', name: 'asm-commons', version: get('asm.version'))
api(group: 'org.ow2.asm', name: 'asm-tree', version: get('asm.version'))
api(group: 'org.assertj', name: 'assertj-core', version: '3.22.0')
api(group: 'org.awaitility', name: 'awaitility', version: '4.2.0')
api(group: 'org.buildobjects', name: 'jproc', version: '2.8.0')
Expand Down
6 changes: 3 additions & 3 deletions geode-assembly/src/integrationTest/resources/assembly_content.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,9 +920,9 @@ lib/ST4-4.3.3.jar
lib/angus-activation-2.0.0.jar
lib/antlr-2.7.7.jar
lib/antlr-runtime-3.5.2.jar
lib/asm-9.10.1.jar
lib/asm-commons-9.10.1.jar
lib/asm-tree-9.10.1.jar
lib/asm-9.11.jar
lib/asm-commons-9.11.jar
lib/asm-tree-9.11.jar
lib/bcprov-jdk18on-1.86.jar
lib/classgraph-4.8.147.jar
lib/classmate-1.5.1.jar
Expand Down
6 changes: 3 additions & 3 deletions geode-assembly/src/integrationTest/resources/gfsh_dependency_classpath.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ snakeyaml-2.5.jar
reactor-core-3.8.7.jar
ST4-4.3.3.jar
txw2-4.0.2.jar
asm-commons-9.10.1.jar
asm-tree-9.10.1.jar
asm-9.10.1.jar
asm-commons-9.11.jar
asm-tree-9.11.jar
asm-9.11.jar
reactive-streams-1.0.4.jar
antlr-runtime-3.5.2.jar
tomcat-embed-el-10.1.42.jar
Expand Down
6 changes: 3 additions & 3 deletions geode-server-all/src/integrationTest/resources/dependency_classpath.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ jspecify-1.0.1.jar
LatencyUtils-2.0.3.jar
snakeyaml-2.5.jar
spring-jcl-6.1.21.jar
asm-commons-9.10.1.jar
asm-tree-9.10.1.jar
asm-9.10.1.jar
asm-commons-9.11.jar
asm-tree-9.11.jar
asm-9.11.jar
txw2-4.0.2.jar
reactor-core-3.8.7.jar
ST4-4.3.3.jar
Expand Down
Loading