Repository navigation
fix(dev): make the pre-flight dedup test independent of glob order - #1428
Merged
Merged
Conversation
test_identical_text_inside_generated_regions_is_invisible took the first SKILL.md from an unsorted glob and asserted it carries the auto pre-flight block. The setup skills carry none, so the test passed or failed depending on filesystem order. It now picks the first carrier in sorted order. Generated-by: Claude Code (Opus 5.5)
potiuk
added
family:tools
13 tasks done
liwenjie200543
added a commit
to liwenjie200543/magpie
that referenced
this pull request
Sep 27, 2026
…ache#1428) The flaky-test fix rode along in this branch; the same fix landed on main as apache#1428 with a sorted-glob implementation, so the rider file both duplicated merged work and was the one conflict blocking the merge. Restore the file to main's version. Generated-by: WorkBuddy (AI agent)
Merged
8 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_identical_text_inside_generated_regions_is_invisibletook the firstSKILL.mdfrom an unsortedgloband asserted it carries the auto pre-flight block.The
setup*skills carry none, so the test passed or failed depending on filesystem order.It now picks the first skill that carries the block, in sorted order.
Three open PRs (#1415, #1369, #1403) each carry their own copy of a fix for this; once this lands they can drop it.
Was generative AI tooling used to co-author this PR?
🤖 Generated with Claude Code