Skip to content

fix(dev): make the pre-flight dedup test independent of glob order #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Sep 27, 2026
Merged

fix(dev): make the pre-flight dedup test independent of glob order #1428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tools/dev/tests/test_check_duplication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,11 @@ def test_identical_text_inside_generated_regions_is_invisible() -> None:
`strip_generated_regions` exists. Reuses a real propagated block from the
live tree so the test tracks the real marker text, not a hand-written
stand-in."""
live_skill = next((REPO / "skills").glob("*/SKILL.md"))
text = live_skill.read_text()
match = MOD.PREFLIGHT_RE.search(text)
assert match, "expected the live skill to carry the auto pre-flight block"
# Not every skill carries the block (the setup skills do not), and glob
# order is filesystem-dependent, so pick the first carrier in sorted order.
matches = (MOD.PREFLIGHT_RE.search(p.read_text()) for p in sorted((REPO / "skills").glob("*/SKILL.md")))
match = next((m for m in matches if m), None)
assert match, "expected at least one live skill to carry the auto pre-flight block"
block = match.group(0)

paragraphs = MOD.extract_paragraphs(
Expand Down