Skip to content

fix: keep JWE key locals scoped #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhuizhuhaomeng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: keep JWE key locals scoped #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/resty/jwt.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ local function parse_jwe(self, preshared_key, encoded_header, encoded_encrypted_
error({reason="unsupported payload encryption algorithm :" .. tostring(header.enc)})
end

local key, enc_key
local key, enc_key, _
if alg == str_const.DIR then
-- RFC 7516 5.2 step 11: direct encryption uses an empty encrypted key
if encoded_encrypted_key ~= str_const.empty then
Expand Down Expand Up @@ -582,7 +582,7 @@ local function sign_jwe(self, secret_key, jwt_obj)
end

-- TODO: implement logic for creating enc key and mac key and then encrypt key
local key, encrypted_key, mac_key, enc_key
local key, encrypted_key, mac_key, enc_key, _
local encoded_header = _M:jwt_encode(header)
local payload_to_encrypt = get_payload_encoder(self)(jwt_obj.payload)
if alg == str_const.DIR then
Expand Down
24 changes: 24 additions & 0 deletions t/jwe-integrity.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,3 +318,27 @@ A128CBC-HS256: true everything is awesome~ :p | false Claim 'foo' ('bar') return
A256GCM: true everything is awesome~ :p | false Claim 'foo' ('bar') returned failure
--- no_error_log
[error]



=== TEST 10: JWE operations do not overwrite the worker global underscore
--- http_config eval: $::HttpConfig
--- config
location /t {
content_by_lua_block {
local jwt = require "resty.jwt"
local sentinel = {}
rawset(_G, "_", sentinel)

local token = jwe_t.sign("A128CBC-HS256")
local obj = jwt:verify(jwe_t.keys["A128CBC-HS256"], token)

ngx.say(obj.verified, " ", rawget(_G, "_") == sentinel)
}
}
--- request
GET /t
--- response_body
true true
--- no_error_log
[error]